Rather than testing upstream functionality for an exact match, we should test that the schema we generate for a spec file validate correctly.
The problem with testing exact schema matching is that it is too tightly coupled to the exact syntax of the schema, even so they might be functionally equivalent, leading to failing unit tests due to upstream schema refinements.
Tips
- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request.
- You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard):
- Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
- Change the review language;
- You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
Rather than testing upstream functionality for an exact match, we should test that the schema we generate for a spec file validate correctly. The problem with testing exact schema matching is that it is too tightly coupled to the exact syntax of the schema, even so they might be functionally equivalent, leading to failing unit tests due to upstream schema refinements.
See this recent CI fail with unrelated changes:
Checklist