glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

🩹🚇 Fix integration test pipeline #1470

Closed s-weigand closed 2 months ago

s-weigand commented 2 months ago

Changing the glotaran/pyglotaran-examples to use notebooks broke the integration test pipeline because the output variable was changed from plots-path to notebook-path.

Change summary

Checklist

sourcery-ai[bot] commented 2 months ago

🧙 Sourcery is reviewing your pull request!


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
github-actions[bot] commented 2 months ago

Binder :point_left: Launch a binder notebook on branch s-weigand/pyglotaran/fix-integration-pipeline

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

Benchmark is done. Checkout the benchmark result page. Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.7.2 vs. main ``` All benchmarks: | Change | Before [1fb14bbc] | After [751502d0] | Ratio | Benchmark (Parameter) | |----------|------------------------------|---------------------|---------|-----------------------------------------| | | 239M | 239M | 1 | IntegrationTwoDatasets.peakmem_optimize | | | 1.50±0.06s | 1.61±0.07s | 1.08 | IntegrationTwoDatasets.time_optimize | ```
Benchmark diff main vs. PR ``` All benchmarks: | Change | Before [751502d0] | After [62caaeba] | Ratio | Benchmark (Parameter) | |----------|----------------------|---------------------|---------|-----------------------------------------| | | 239M | 240M | 1 | IntegrationTwoDatasets.peakmem_optimize | | | 1.61±0.07s | 1.54±0.1s | 0.96 | IntegrationTwoDatasets.time_optimize | ```
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.6%. Comparing base (2c88dce) to head (62caaeb). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1470 +/- ## ===================================== Coverage 88.6% 88.6% ===================================== Files 107 107 Lines 5128 5133 +5 Branches 962 965 +3 ===================================== + Hits 4544 4549 +5 Misses 468 468 Partials 116 116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.