Closed joernweissenborn closed 2 months ago
🧙 Sourcery has finished reviewing your pull request!
Attention: Patch coverage is 87.50000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 85.2%. Comparing base (
2d0fc21
) to head (0884198
).
Files | Patch % | Lines |
---|---|---|
glotaran/optimization/optimization.py | 50.0% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Evaluated PR running study_fluorescence\fluorescence_global_and_target_analysis.ipynb
.
On main:
Before this PR:
AFter this PR:
Conclusion: this does indeed resolve issue 1474.
Fixes #1474
additional_penalty
to the result object and renamesnr_clp
back tonumber_of_clps
.