glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

Fix 1474 - add fields to result object - correct calculation of number of clps. #1484

Closed joernweissenborn closed 2 months ago

joernweissenborn commented 2 months ago

Fixes #1474

github-actions[bot] commented 2 months ago

Binder :point_left: Launch a binder notebook on branch _joernweissenborn/pyglotaran/staging1474

sourcery-ai[bot] commented 2 months ago

🧙 Sourcery has finished reviewing your pull request!


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.2%. Comparing base (2d0fc21) to head (0884198).

Files Patch % Lines
glotaran/optimization/optimization.py 50.0% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## staging #1484 +/- ## ======================================= Coverage 85.2% 85.2% ======================================= Files 91 91 Lines 3735 3756 +21 Branches 726 734 +8 ======================================= + Hits 3184 3203 +19 - Misses 438 440 +2 Partials 113 113 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsnel commented 2 months ago

Evaluated PR running study_fluorescence\fluorescence_global_and_target_analysis.ipynb.

On main: image Before this PR: image AFter this PR: image

Conclusion: this does indeed resolve issue 1474.