Closed jsnel closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.3%. Comparing base (
8dfac94
) to head (fe69696
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Status of the compare results test
Currently on staging: ================ 159 failed, 418 passed, 49 warnings in 14.00s =================
With the changes in this PR: ================ 148 failed, 429 passed, 49 warnings in 13.75s =================
TODO: add some unit tests for parameter resolving (this is why PR is still in DRAFT)
Reduced the number of errors in the comparison further by adjusting the order of the scheme definition in the fluorescence example to preserve the order of compartments.
New status: ================ 141 failed, 436 passed, 49 warnings in 14.14s =================
This is actually lingering much longer, like very long. I never thought much about it but yeah, parameter order matters with related stuff.
The fix is totally correct. Would lgtm it now but you want to add a test.
🧙 Sourcery has finished reviewing your pull request!
Unit tests were added to check (specifically) for the issue that this PR fixes (incorrect order of parameters).
The final result remains unchanged: ================ 141 failed, 436 passed, 49 warnings in 13.83s =================
The PR is ready for review now.
Add the dependent parameters after its dependencies.
Parameters involved in a relation (parameter expression) should be added before the parameter that declares a dependency on them.
Change summary
Checklist
Closes issues
closes #1499