glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

[staging] 🐛 Run Examples / Compare Results has (too many) fails #1501

Open jsnel opened 2 months ago

jsnel commented 2 months ago

Version information

Describe the bug

A number of attributes are missing in the (result) datasets created from staging, compared to main, resulting in a failing result comparison tests, as can be observed in a recent PR.

Last comparison results action resulting in: ================ 141 failed, 436 passed, 49 warnings in 14.14s =================

A non-exaustive list of issues (to see all, check the actions):

To Reproduce

Steps to reproduce the behavior:

Open a PR to staging, observe the results of the action: Run Examples / Compare Results (pull_request)

Expected behavior

A smaller number of failing tests (maybe not 0, but a lot smaller than 141).

Tiny numerical differences can be acceptable, but we need to eliminate fails because of missing attributes.

Additional context

Note that we already worked around a lot of issues in the compat module and the examples module itself, ideally we need to do less of that.

Compat modules:

pyglotaran_examples staging changes: