🧹🚇 Remove asv benchmarks and binder integration

glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data

GNU Lesser General Public License v3.0

53 stars 18 forks source link

🧹🚇 Remove asv benchmarks and binder integration #1511

Closed s-weigand closed 3 weeks ago

s-weigand commented 3 weeks ago

Since the 0.8 rewrite will drop ASV benchmarks there is no point in sticking to them and maintaining them on main. Binder has not been functional for quite some time (startup timeout), so there is no point in keeping it.

Change summary

Checklist

[x] ✔️ Passing the tests (mandatory for all PR's)
[x] 🚧 Added changes to changelog (mandatory for all PR's)

sourcery-ai[bot] commented 3 weeks ago

🧙 Sourcery has finished reviewing your pull request!

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

github-actions[bot] commented 3 weeks ago

:point_left: Launch a binder notebook on branch s-weigand/pyglotaran/remove-asv-benchmarks

sonarcloud[bot] commented 3 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.6%. Comparing base (2c88dce) to head (8993915). Report is 13 commits behind head on main.

Files	Patch %	Lines
glotaran/typing/types.py	0.0%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1511 +/- ## ===================================== Coverage 88.6% 88.6% ===================================== Files 107 107 Lines 5128 5133 +5 Branches 962 965 +3 ===================================== + Hits 4544 4549 +5 Misses 468 468 Partials 116 116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.