glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

🩹 Fix ordering bug in MatrixProvider class #1512

Closed jsnel closed 3 weeks ago

jsnel commented 3 weeks ago

In the call to combine_megacomplex_matrices the matrices would be reordered independent of their labels resulting in a combined matrix that would be ordered differently than expected. This issue was specifically found in the case of multiple types of different megacomplexes.

This bug fix was orginally part of #1510 but was seperated out because of its broader scope.

Change summary

Checklist

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.6%. Comparing base (2c88dce) to head (dae1d94). Report is 17 commits behind head on main.

Files Patch % Lines
glotaran/optimization/matrix_provider.py 0.0% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1512 +/- ## ======================================= - Coverage 88.6% 88.6% -0.1% ======================================= Files 107 107 Lines 5128 5134 +6 Branches 962 965 +3 ======================================= + Hits 4544 4549 +5 - Misses 468 469 +1 Partials 116 116 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sourcery-ai[bot] commented 3 weeks ago

🧙 Sourcery has finished reviewing your pull request!


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud