glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

🩹 Fix AttributeError validating bad DOAS user definition #1513

Closed s-weigand closed 3 weeks ago

s-weigand commented 3 weeks ago

During the review of #1510 we found an inherited bug from the DOAS megacomplex where a faulty user definition would raise an AttributeError when the ItemIssue get converted to a string that is show to users.

Change summary

Checklist

sourcery-ai[bot] commented 3 weeks ago

🧙 Sourcery has finished reviewing your pull request!


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.7%. Comparing base (2c88dce) to head (5e1c3b0). Report is 17 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1513 +/- ## ======================================= + Coverage 88.6% 88.7% +0.1% ======================================= Files 107 107 Lines 5128 5134 +6 Branches 962 965 +3 ======================================= + Hits 4544 4556 +12 + Misses 468 463 -5 + Partials 116 115 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud