glotaran / pyglotaran

A Python library for Global and Target Analysis of time-resolved spectroscopy data
GNU Lesser General Public License v3.0
53 stars 18 forks source link

🩹 Use .data attribute in add_svd_to_dataset function to fix numpy>2 issue #1522

Closed jsnel closed 3 weeks ago

jsnel commented 3 weeks ago

Forward port of #1520

Change summary

Checklist

sourcery-ai[bot] commented 3 weeks ago

🧙 Sourcery has finished reviewing your pull request!


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
github-actions[bot] commented 3 weeks ago

Binder :point_left: Launch a binder notebook on branch _jsnel/pyglotaran/fix_numpy_2_issuesstaging

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.3%. Comparing base (f21ca65) to head (dcd45ed). Report is 1 commits behind head on staging.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## staging #1522 +/- ## ======================================= Coverage 85.3% 85.3% ======================================= Files 91 91 Lines 3756 3756 Branches 734 734 ======================================= Hits 3205 3205 Misses 439 439 Partials 112 112 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsnel commented 3 weeks ago

All tests except Compare Results are passing. The results is unchanged w.r.t. previous PR (e.g. #1501). So this should be good to go.