search

glotzerlab / freud

Powerful, efficient particle trajectory analysis in scientific Python.
https://freud.readthedocs.io
BSD 3-Clause "New" or "Revised" License
276 stars 49 forks source link

Implement new bimap #104

Closed bdice closed 6 years ago

bdice commented 8 years ago

Original report by Eric Harper (Bitbucket: harperic, GitHub: harperic).

Replace boost::bimap with Alex's bimap.

bdice commented 6 years ago

Original comment by Bradley Dice (Bitbucket: bdice, GitHub: bdice).

Complete: https://bitbucket.org/glotzer/freud/pull-requests/163/bimap-replacement

bdice commented 6 years ago

Original comment by Vyas Ramasubramani (Bitbucket: vramasub, GitHub: vyasr).

@matthewpalathingal if you have questions feel free to email me, I will be responsive this week, just shifted by 9 hours.

bdice commented 6 years ago

Original comment by Bradley Dice (Bitbucket: bdice, GitHub: bdice).

Assigning issue to Matt P since he has begun work on this.

bdice commented 6 years ago

Original comment by Bradley Dice (Bitbucket: bdice, GitHub: bdice).

Related issue: #105

bdice commented 6 years ago

Original comment by Bradley Dice (Bitbucket: bdice, GitHub: bdice).

@alxdttn @erteich Can you tell me the current progress of this? Has the code been implemented? It appears the master branch still has boost::bimap in use. The branch bimap_fix doesn't appear to compile (based on the commit log). https://bitbucket.org/glotzer/freud/branch/bimap_fix

bdice commented 7 years ago

Original comment by Eric Harper (Bitbucket: harperic, GitHub: harperic).

@alxdttn @erteich we should meet to discuss implementing this soon.

bdice commented 7 years ago

Original comment by Eric Harper (Bitbucket: harperic, GitHub: harperic).

@alxdttn we should meed and figure this out