Enable cmake color output for clang/ninja - Githubissues

glotzerlab / freud

Powerful, efficient particle trajectory analysis in scientific Python.

https://freud.readthedocs.io

BSD 3-Clause "New" or "Revised" License

282 stars 49 forks source link

Enable cmake color output for clang/ninja #1287

Closed janbridley closed 1 month ago

janbridley commented 1 month ago

As in ninja-build/Ninja's FAQ, cmake does not color output for build systems that buffer output. The code added in this PR fixes this

How Has This Been Tested?

CMake colors output with the changes made, and does not without.

Before:

After:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds or improves functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[x] I have updated the documentation (if relevant).
[x] I have added tests that cover my changes (if relevant).
[x] All new and existing tests passed.
[x] I have updated the credits.
[x] I have updated the Changelog.

joaander commented 1 month ago

Merged up into nanobind.