search

glotzerlab / hoomd-blue

Molecular dynamics and Monte Carlo soft matter simulation on GPUs.
http://glotzerlab.engin.umich.edu/hoomd-blue
BSD 3-Clause "New" or "Revised" License
335 stars 131 forks source link

ALJ Overlap Check #1293

Closed tommy-waltmann closed 1 year ago

tommy-waltmann commented 2 years ago

Description

The code which implements the overlap check in ALJ may give false positives and false negatives. When scripts are run using a debug build, this can cause unwanted failures in an assert statement in the evaluator code. This bug does not affect simulation results given a proper initial condition, so it does not affect any hoomd releases.

This issue would require significant developer time and effort to fix, and would require a detailed knowledge of the GJK algorithm as a prerequisite for trying to fix it.

I am making this issue to document that this is something that can happen in the ALJ code in debug builds, not to try and get an immediate solution for the bug.

Platform:

Installation method:

Versions:

Developer

Any developer who has the time, prerequisite knowledge, and the motivation to do it.

joaander commented 2 years ago

Fixed in #1292

vyasr commented 2 years ago

I believe that #1292 fixes #1282. This issue was opened by @tommy-waltmann to track future work.

joaander commented 2 years ago

You are correct.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] commented 1 year ago

This issue has been automatically closed because it has not had recent activity.