Project still installs MPI-related files when built with ENABLE_MPI=OFF

glotzerlab / hoomd-blue

Molecular dynamics and Monte Carlo soft matter simulation on GPUs.

http://glotzerlab.engin.umich.edu/hoomd-blue

BSD 3-Clause "New" or "Revised" License

329 stars 127 forks source link

Project still installs MPI-related files when built with ENABLE_MPI=OFF #1398

Closed yurivict closed 2 years ago

yurivict commented 2 years ago

Description

These MPI-related files are installed:

%%PYTHON_SITELIBDIR%%/hoomd/include/hoomd/HOOMDMPI.h
%%PYTHON_SITELIBDIR%%/hoomd/include/hoomd/MPIConfiguration.h
%%PYTHON_SITELIBDIR%%/hoomd/include/hoomd/extern/dfftlib/CUDA_MPI.cmake

Versions:

Python version: 3.9
HOOMD-blue version: 3.4.0

joaander commented 2 years ago

Thanks for reporting. These files must be present for users to build external components. They may have MPI in the name, but they are included by other files even when ENABLE_MPI is not set: https://github.com/glotzerlab/hoomd-blue/blob/e17d2d391d8734fd5e8538de9ee45179a175db37/hoomd/Messenger.h#L8-L14