glotzerlab / signac-dashboard

Rapidly visualize signac projects through a customizable dashboard interface.
https://signac.io
BSD 3-Clause "New" or "Revised" License
16 stars 6 forks source link

Release/0.6.0 #194

Closed cbkerr closed 1 year ago

cbkerr commented 1 year ago

Description

Release Navigator module and Login page plus security fixes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #194 (3589c75) into main (81981c1) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   69.98%   69.98%           
=======================================
  Files          21       21           
  Lines         883      883           
  Branches      159      159           
=======================================
  Hits          618      618           
  Misses        220      220           
  Partials       45       45           
Files Changed Coverage Δ
signac_dashboard/version.py 100.00% <100.00%> (ø)
cbkerr commented 1 year ago

The run of the Publish to TestPyPI check after the pre-commit bot failed, but I think the publication worked because the URL is live: https://test.pypi.org/project/signac-dashboard/0.6.0/

cbkerr commented 1 year ago

It looks like it uploaded right, but it may still be worth looking the failure report. Is that action failing something that typically happens on release?

I should have pasted the error, but yes it was that the file was uploaded already:

WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         File already exists. See https://test.pypi.org/help/#file-name-reuse   
         for more information. 

I recall something like this happening on an earlier release where there were extra steps (and one time where I made the version tag wrong) but I think any Slack chat history about it is deleted bc it's been more than 90 days.

joaander commented 1 year ago

It looks like it uploaded right, but it may still be worth looking the failure report. Is that action failing something that typically happens on release?

I should have pasted the error, but yes it was that the file was uploaded already:

WARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://test.pypi.org/legacy/          
         File already exists. See https://test.pypi.org/help/#file-name-reuse   
         for more information. 

I recall something like this happening on an earlier release where there were extra steps (and one time where I made the version tag wrong) but I think any Slack chat history about it is deleted bc it's been more than 90 days.

I use the skip_existing option to silence this type of error: https://github.com/glotzerlab/gsd/blob/de226fed1862ae2a3a76ac9ef06ce6df4eb970f5/.github/workflows/build_wheels.yml#L99C2-L107

The alternative is to add a suffix to the generated wheel so that each upload succeeds. However, you may then accumulate MANY wheels in the testpypi project.

bdice commented 1 year ago

Historically this has always failed if multiple commits are pushed to a release branch — and “skip existing” sounds like the right way to fix this problem. I wasn’t aware of that option when I set up the deployment workflow but would support adding that flag.