glotzerlab / signac-examples

Examples for the signac framework.
https://signac.io/
BSD 3-Clause "New" or "Revised" License
14 stars 8 forks source link

Clean metadata and user paths in notebook outputs #25

Closed bdice closed 3 years ago

bdice commented 3 years ago

This is an update to #22 that strips unnecessary metadata and user paths from the notebooks. I have added pre-commit hooks and a helper script .render_all_notebooks.sh to assist with rendering and cleaning the notebooks.

Warning: I rendered these notebooks with development versions of signac and signac-flow to fix some bugs that caused warnings in the notebook outputs! The PRs fixing these issues are:

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mikemhenry commented 3 years ago

So do we only need to merge this one and not #22 ?

bdice commented 3 years ago

@mikemhenry This merges into #22, I just wanted to separate my changes since it was somewhat experimental.

mikemhenry commented 3 years ago

:man_facepalming: That's what I get for not reading