search

glowabio / geofresh

https://geofresh.org
GNU General Public License v3.0
0 stars 3 forks source link

User feedback when point falls into the ocean or hole #35

Closed vanbremer closed 4 months ago

vanbremer commented 9 months ago

Users need to be notified if no sub-catchment ID is returned from query. Points should be discarded from further queries for now.

vanbremer commented 9 months ago

If points do not overlap with regional unit polygon reg_id will be empty --> check table for null values and notify user second step: check if sub_id is returned --> if not give message about "hole" if "hole" check if point falls into a lake --> give back information on Lake ID link Lake ID to corresponding outlet/basin ID and use this for upstream calculation (no local information?)

tomitho commented 8 months ago

Almost fixed! So far users are notified when points are not located in a sub-catchment. This either results from that points are located in the ocean or inside a lake. Lake Ids still need to be integrated. Then lake information needs to be returned when points fall into lakes.