glowfic-constellation / glowfic

The Glowfic Constellation
https://www.glowfic.com
MIT License
16 stars 10 forks source link

Bump aws-sdk-rails from 3.13.0 to 4.0.2 #2131

Closed dependabot[bot] closed 1 month ago

dependabot[bot] commented 1 month ago

Bumps aws-sdk-rails from 3.13.0 to 4.0.2.

Release notes

Sourced from aws-sdk-rails's releases.

Release v4.0.2 - 2024-07-22

Tag release v4.0.2

References: #134, #135

  • Issue - Do not require action_mailbox/engine in Aws::Rails::ActionMailbox::Engine and instead check for its existence.

  • Issue - Refactor the loading of the SQS ActiveJob adapter to be in aws/rails/sqs_active_job.

Release v4.0.1 - 2024-07-18

Tag release v4.0.1

References: #132

  • Issue - Require action_mailbox/engine from Aws::Rails::ActionMailbox::Engine.

Release v4.0.0 - 2024-07-18

Tag release v4.0.0

References: #127, #128, #129, #130, #131

  • Feature - Add support for Action Mailbox with SES (#127).

  • Issue - Ensure :ses or :sesv2 as ActionMailer configuration.

  • Issue - Do not allow :amazon, amazon_sqs, or amazon_sqs_async for SQS active job configuration. Instead use :sqs and :sqs_async.

Changelog

Sourced from aws-sdk-rails's changelog.

4.0.2 (2024-07-22)

  • Issue - Do not require action_mailbox/engine in Aws::Rails::ActionMailbox::Engine and instead check for its existence.

  • Issue - Refactor the loading of the SQS ActiveJob adapter to be in aws/rails/sqs_active_job.

4.0.1 (2024-07-18)

  • Issue - Require action_mailbox/engine from Aws::Rails::ActionMailbox::Engine.

4.0.0 (2024-07-18)

  • Feature - Add support for Action Mailbox with SES (#127).

  • Issue - Ensure :ses or :sesv2 as ActionMailer configuration.

  • Issue - Do not allow :amazon, amazon_sqs, or amazon_sqs_async for SQS active job configuration. Instead use :sqs and :sqs_async.

Commits
  • 366f1ad Bumped version to v4.0.2
  • a7810fa Check if action mailbox config is defined (#135)
  • 8ff5279 Consolidate the loading of modules related to AWS SQS ActiveJob (#134)
  • a61a580 Fix rubocop
  • df84bed Simplify CI
  • 5d8be4f Added next release section to the changelog. [ci skip]
  • 9e2cc76 Bumped version to v4.0.1
  • 4ba9d91 Require action mailbox engine by default (#132)
  • c1c1e89 Added next release section to the changelog. [ci skip]
  • a641c3a Bumped version to v4.0.0
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Throne3d commented 1 month ago

Mailer method changed, specs breaking as a result

https://github.com/aws/aws-sdk-rails?tab=readme-ov-file#override-credentials-or-other-client-options

# config/initializers/aws.rb
Aws::Rails.add_action_mailer_delivery_method(:aws_ses) # should switch to :ses or :sesv2 instead
# config/environments/production.rb
  config.action_mailer.delivery_method = :aws_ses # same

Info on V1 vs V2: https://aws.amazon.com/blogs/messaging-and-targeting/upgrade-your-email-tech-stack-with-amazon-sesv2-api/#:~:text=Why%20migrate%20to%20Amazon%20SESv2%20API%3F

Throne3d commented 1 month ago

Logic used to be:

        if name == :sesv2
          add_delivery_method(name, Aws::Rails::Sesv2Mailer, client_options)
        else
          add_delivery_method(name, Aws::Rails::SesMailer, client_options)

(now instead requires :ses or :sesv2 and otherwise performs raise ArgumentError, "Unknown action mailer delivery method: #{name}" for unknown entries) so we should probably migrate to :ses for equal behavior