search

glowfic-constellation / glowfic

The Glowfic Constellation
https://www.glowfic.com
MIT License
16 stars 10 forks source link

Consider disabled rubocop cops #997

Open teceler opened 5 years ago

teceler commented 5 years ago

While I'm thinking about rubocop cops, ones we might wanna look at but that had a bunch of complaints: Layout/EmptyLineAfterMagicComment Layout/EmptyLineAfterGuardClause (iffy on this one, but worth looking at) Layout/SpaceAroundOperators Layout/SpaceInsideHashLiteralBraces

Naming/AccessorMethodName Naming/PredicateName

Style/AndOr Style/BlockDelimiters Style/BracesAroundHashParameters Style/GuardClause Style/HashSyntax Style/MutableConstant Style/StringLiterals Style/SymbolArray (configured to brackets probably xD) Style/TernaryParentheses Style/TrailingCommaInArrayLiteral Style/TrailingCommaInHashLiteral

teceler commented 2 years ago

We've since enabled all but: Layout/EmptyLineAfterMagicComment Layout/EmptyLineAfterGuardClause Naming/AccessorMethodName Naming/PredicateName Style/GuardClause (PR: #1612) Style/HashSyntax (PR: #1609) Style/MutableConstant Style/StringLiterals Style/SymbolArray Style/TernaryParentheses