glpi-project / glpi-agent

GLPI Agent
GNU General Public License v2.0
212 stars 51 forks source link

RustDesk ID scan break with new RustDesk 1.2.3-1 #609

Closed NicoUnterburger closed 4 months ago

NicoUnterburger commented 4 months ago

Bug reporting acknowledgment

Yes, I read it

Professional support

Yes, I know

Describe the bug

With new Rustdesk Version "1.2.3-1" glpi-agent cant receive the ID. I thin Problem is the new "-1" on Version, which cant veriffied by GLPI, so the Script will break up.

If I remove the Version check in RustDesk.pm, line 48-54, the ID is transferred correct.

To reproduce

Install actual RustDesk-Agent (1.2.3-1) and try to collect inventory. Result: Can't get RustDesk ID, RustDesk is probably not running

Expected behavior

Can view the RustDesk-ID in GLPI-Dashboard

Operating system

Windows

GLPI Agent version

1.7

GLPI version

10.0.12

GLPIInventory plugin or FusionInventory for GLPI plugin version

GLPI Inventory v1.3.4

Additional context

No response

g-bougard commented 4 months ago

Hi @NicoUnterburger

you're probably right and I'm afraid people codes simple stuffs in a so much weird way in that project...

Can you share the output of the following command run to be sure to include the right fix ?

"C:\Program Files\RustDesk\rustdesk.exe" --version
NicoUnterburger commented 4 months ago

Hi @g-bougard here you find the output of the above command:

PS C:\Program Files\RustDesk> .\rustdesk.exe --version PS C:\Program Files\RustDesk> .\rustdesk.exe --version | out-host 1.2.3-1

g-bougard commented 4 months ago

Hi @NicoUnterburger

thank you for that sharing, the next nightly build should include the fix I just pushed.

mmarodin commented 3 months ago

There is still the same issue using the new 1.7.2 glpi-agent. Could you fix it? :) Thanks

g-bougard commented 3 months ago

Hello @mmarodin

that issue is fixed in nightlies and 1.7.2 is just a security fix regarding 1.7.1. This means the next release including this fix will be 1.8 version. That version should be released in few weeks.