glpi-project / glpi-inventory-plugin

GLPI Inventory plugin
GNU Affero General Public License v3.0
46 stars 27 forks source link

"taskscheduler" automatic action doesn't report the number of updated tasks #522

Closed eduardomozart closed 3 months ago

eduardomozart commented 4 months ago

Describe the bug

When running the "taskscheduler" automatic action, it updates the task status to "Preparing" but the "Number" column does not report the number of changed tasks status (it's always "0").

image

To reproduce

  1. Run automatic action "taskscheduler".

Expected behavior

The "Numbers" column should reflect the number of tasks status updated.

Operating system

Windows

GLPI Agent version

Other (See additional context below)

GLPI version

Other (See additional context below)

GLPIInventory plugin

1.3.5

Additional context

GLPI Agent version: 1.9 GLPI version: 10.0.16

stonebuzz commented 4 months ago

Hi @eduardomozart taskscheduler it works mainly on the agents to be prepared in the tasks

We could (possibly) count the agents prepared, but I'm not sure about the relevance of this information (the total changes depending on the task, doesn't allow you to go back to the task, etc.).

eduardomozart commented 4 months ago

It would be more useful than "0", even if it doesn't report the task name itself, as the admin would know that it's task is being handled and prepared to run by this task, and if the number didn't increase, it can troubleshoot somewhere else.

stonebuzz commented 4 months ago

Hi @eduardomozart can you try this -> https://github.com/glpi-project/glpi-inventory-plugin/pull/525

eduardomozart commented 4 months ago

I can confirm this fix seems to be working as expected.