derry43
commented
2 years ago After a bit of digging, this issue appears to be cause by lines 1438 to 1448 in src/KnowbaseItem.php which replaces all of the Boolean Full-Text Search (BOOLEAN MODE) operators with spaces, resulting in them being ignored.
// Replace all non word characters with spaces (see: https://stackoverflow.com/a/26537463)
$search_wilcard = preg_replace('/[^\p{L}\p{N}_]+/u', ' ', $search);
// Remove last space to avoid illegal syntax with " *"
$search_wilcard = trim($search_wilcard);
// Merge spaces since we are using them to split the string later
$search_wilcard = preg_replace('!\s+!', ' ', $search_wilcard);
$search_wilcard = explode(' ', $search_wilcard);
$search_wilcard = implode('* ', $search_wilcard) . '*';I believe that this should be:
// Replace all non word/operator characters with spaces (see: https://stackoverflow.com/a/26537463)
$search_wilcard = preg_replace('/[^\p{L}\p{N}_)(~+\<>*"-]+/u', ' ', $search);
// Remove last space to avoid illegal syntax with " *"
$search_wilcard = trim($search_wilcard);
// Merge spaces since we are using them to split the string later
$search_wilcard = preg_replace('!\s+!', ' ', $search_wilcard);
$search_wilcard = explode(' ', $search_wilcard);
$search_wilcard = implode('* ', $search_wilcard);
Similar lines in 9.5.7 inc/knowbaseitem_class.php can be updated to fix for current release.
cconard96
cedric-anne
Code of Conduct
Is there an existing issue for this?
Version
10.0 RC3
Bug description
The Boolean Full-Text Search operators (+, -, ~, *, <, >, () and "") are ignored in the Knowledge base search and therefor do not work as per the documentation (doc excerpt below). A possible fix is provided in the additional comments made after raising this bug report.
My experience has shown that searching for articles with lines that must contain both the words "tribbles" and "with" by using the search expression
+tribbles +withwill return all articles containing either "with" or "tribbles", the same as simply using the search termtribbles with. Effectively ignoring the+operator.And searching for articles that must contain the literal sequence "with tribbles" by using the search expression
"with tribbles"returns all articles containing either "with" or "tribbles", the same as simply using the search termtribbles with. Effectively ignoring the"quotes.Worse still, searching for articles that must contain "tribbles" but must not contain "kirk" by using the search expression
+tribbles -kirkalso returns all articles containing either "tribbles" or "kirk", the same as simply using the search termtribbles kirk. Effectively ignoring the-operator.Documentation on Knowledge Base Search Operators
Relevant log output
No response
Page URL
front/knowbaseitem.php
Steps To reproduce
+tribbles +with"with tribbles"+tribbles -kirkYour GLPI setup information
Information about system installation and configuration
Server
Operating system: Windows NT EMPCRUUKWPBU012 6.3 build 9600 (Windows Server 2012 R2 Standard Edition) AMD64 PHP 7.4.15 cgi-fcgi (Core, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apcu, bcmath, bz2, calendar, cgi-fcgi, ctype, curl, date, dom, exif, fileinfo, filter, gd, gettext, hash, iconv, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, readline, session, soap, sodium, standard, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, zip, zlib) Setup: max_execution_time="300" memory_limit="128M" post_max_size="8M" safe_mode="" session.save_handler="files" upload_max_filesize="10M" Software: Microsoft-IIS/8.5 Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.75 Safari/537.36 Edg/100.0.1185.36 Server Software: MySQL Community Server - GPL Server Version: 8.0.23 Server SQL Mode: STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION Parameters: glpi@172.16.2.70/glpi10x Host info: 172.16.2.70 via TCP/IP PHP version (7.4.15) is supported. Sessions configuration is OK. Allocated memory is sufficient. mysqli extension is installed. Following extensions are installed: dom, fileinfo, json, simplexml. curl extension is installed. gd extension is installed. intl extension is installed. libxml extension is installed. zlib extension is installed. The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present. Database engine version (8.0.23) is supported. The log file has been created successfully. Write access to C:\inetpub\wwwroot\glpi10x/files/_cache has been validated. Write access to C:\inetpub\wwwroot\glpi10x/config has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files/_cron has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files/_dumps has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files/_graphs has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files/_lock has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files/_pictures has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files/_plugins has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files/_rss has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files/_sessions has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files/_tmp has been validated. Write access to C:\inetpub\wwwroot\glpi10x/files/_uploads has been validated. Web access to the files directory should not be allowed but this cannot be checked automatically on this instance. Make sure access to error log file (/files/_log/php-errors.log) is forbidden; otherwise review .htaccess file and web server configuration. exif extension is installed. ldap extension is installed. openssl extension is installed. zip extension is installed. bz2 extension is installed. Zend OPcache extension is installed. Following extensions are installed: ctype, iconv, mbstring, sodium. Write access to C:\inetpub\wwwroot\glpi10x/marketplace has been validated. Timezones seems loaded in database.GLPI constants
Libraries
LDAP directories
Server: 'ldap://empcruukwpdc001.navsys.ad', Port: '636', BaseDN: 'DC=NAVSYS,DC=ad', Connection filter: '(&(objectClass=user)(objectCategory=person)(memberof=CN=_ActiveUsers,OU=Groups,OU=Naval,DC=NAVSYS,DC=ad)(!(userAccountControl:1.2.840.113556.1.4.803:=2)))', RootDN: 'ldapnex@navsys.ad', Use TLS: noneSQL replicas
Notifications
Plugins list
activity Name: Activities Version: 3.0.0 State: Error / to clean actualtime Name: ActualTime Version: 1.5.0 State: Error / to clean fields Name: Additionnal fields Version: 1.12.4 State: Error / to clean advancedplanning Name: advancedplanning Version: 1.0.0 State: Error / to clean news Name: Alerts Version: 1.9.0 State: Error / to clean appliances Name: Appliances Version: 3.1.1 State: Error / to clean archisw Name: Apps structures Version: 2.2.9 State: Enabled impacts Name: Asset impacts Version: 2.0.5 State: Error / to clean behaviors Name: Behaviours Version: 2.5.0 State: Error / to clean archibp Name: Business Processes Version: 1.0.3 State: Error / to clean positions Name: Cartography Version: 5.0.0 State: Error / to clean cmdb Name: CMDB Version: 2.2.1 State: Error / to clean cve Name: CVE Version: 1.0.0 State: Error / to clean dashboard Name: Dashboard Version: 1.0.2 State: Error / to clean datainjection Name: Data injection Version: 2.10.1 State: Error / to clean databases Name: Databases Version: 2.3.2 State: Error / to clean archimap Name: Diagrams Version: 3.2.2 State: Installed / not activated father Name: Father&Sons Version: 1.2.0 State: Error / to clean formcreator Name: Form Creator Version: 2.11.2 State: Error / to clean archifun Name: Functional Areas Version: 2.2.2 State: Error / to clean fusioninventory Name: FusionInventory Version: 9.5+3.0 State: Error / to clean resources Name: Human Resources Version: 2.7.4 State: Error / to clean geninventorynumber Name: Inventory number generation Version: 2.5.0 State: Error / to clean addressing Name: IP Adressing Version: 2.9.0 State: Error / to clean uninstall Name: Item's Lifecycle (uninstall) Version: 2.7.0 State: Error / to clean itilcategorygroups Name: ItilCategory Groups Version: 2.4.1 State: Error / to clean ldapcomputers Name: LDAP computers Version: 0.4.1 State: Error / to clean metademands Name: Meta-Demands Version: 2.7.5 State: Error / to clean metabase Name: metabase Version: 1.2.4 State: Error / to clean mreporting Name: More Reporting Version: 1.7.3 State: Error / to clean genericobject Name: Objects management Version: 2.11.0 State: Error / to clean order Name: Orders management Version: 2.7.2 State: Error / to clean example Name: Plugin Example Version: 0.0.1 State: Error / to clean pdf Name: Print to pdf Version: 2.0.0 State: Error / to clean projectbridge Name: Projectbridge Version: 2.4 State: Error / to clean releases Name: Releases Version: 1.0.1 State: Error / to clean reports Name: Reports Version: 1.14.1 State: Error / to clean shellcommands Name: Shell Commands Version: 3.0.0 State: Error / to clean tag Name: Tag Management Version: 2.8.1 State: Error / to clean taskdrop Name: TaskDrop Version: 1.3.0 State: Error / to clean tasklists Name: Tasks list Version: 1.6.2 State: Error / to clean useditemsexport Name: Used items export Version: 2.3.0 State: Error / to clean vip Name: VIP Version: 1.4RC1 State: Error / to clean webapplications Name: Web applications Version: 4.0.0-rc1 State: Enabled webresources Name: Web Resources Version: 1.3.2 State: Error / to cleanAnything else?
No response