glpi-project / glpi

GLPI is a Free Asset and IT Management Software package, Data center management, ITIL Service Desk, licenses tracking and software auditing.
https://glpi-project.org
GNU General Public License v3.0
4.18k stars 1.28k forks source link

Cron Task return Agent error #11807

Closed brunnersm closed 2 years ago

brunnersm commented 2 years ago

Code of Conduct

Is there an existing issue for this?

Version

10.0.1

Bug description

Return error in php-errros.log with php front/cron.php about src/Agent.php

Relevant log output

php-erros.log
glpiphplog.CRITICAL:   *** Uncaught Exception Error: Class name must be a valid object or a string in /var/www/html/src/Agent.php at line 371
  Backtrace :
  src/Agent.php:388                                  Agent->getLinkedItem()
  src/Agent.php:488                                  Agent->guessAddresses()
  src/Agent.php:524                                  Agent->getAgentURLs()
  src/Agent.php:572                                  Agent->requestAgent()
  ...ace/glpiinventory/inc/agentwakeup.class.php:176 Agent->requestStatus()
  src/CronTask.php:1018                              PluginGlpiinventoryAgentWakeup::cronWakeupAgents()
  front/cron.php:84                                  CronTask::launch()

Page URL

No response

Steps To reproduce

php /var/www/html/front/cron.php &>/dev/null

Your GLPI setup information

Instruções de instalação e configuração
GLPI 10.0.1 ( => /var/www/html)
Installation mode: TARBALL
Current language:pt_BR

Server
 
Operating system: Linux HUCAM-VP-CAU1 4.19.0-9-amd64 #1 SMP Debian 4.19.118-2+deb10u1 (2020-06-07) x86_64
PHP 7.4.8 apache2handler (Core, FFI, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, apc, apcu, bcmath,
    bz2, calendar, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imap, intl, json, ldap, libxml,
    mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, posix, readline, session, shmop, sockets, sodium, standard, sysvmsg,
    sysvsem, sysvshm, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib)
Setup: max_execution_time="30" memory_limit="128M" post_max_size="8M" safe_mode="" session.save_handler="files"
    upload_max_filesize="2M" 
Software: Apache/2.4.38 (Debian) (Apache/2.4.38 (Debian) Server at cau.hucam.edu.br Port 443
)
    Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/101.0.4951.64 Safari/537.36 Edg/101.0.1210.53
Server Software: mariadb.org binary distribution
    Server Version: 10.5.4-MariaDB-1:10.5.4+maria~buster
    Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
    Parameters: root@localhost/glpi
    Host info: Localhost via UNIX socket

PHP version (7.4.8) is supported.
Sessions configuration is OK.
Allocated memory is sufficient.
mysqli extension is installed.
Following extensions are installed: dom, fileinfo, json, simplexml.
curl extension is installed.
gd extension is installed.
intl extension is installed.
libxml extension is installed.
zlib extension is installed.
The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present.
Database engine version (10.5.4) is supported.
The log file has been created successfully.
Write access to /var/www/html/files/_cache has been validated.
Write access to /var/www/html/config has been validated.
Write access to /var/www/html/files/_cron has been validated.
Write access to /var/www/html/files has been validated.
Write access to /var/www/html/files/_dumps has been validated.
Write access to /var/www/html/files/_graphs has been validated.
Write access to /var/www/html/files/_lock has been validated.
Write access to /var/www/html/files/_pictures has been validated.
Write access to /var/www/html/files/_plugins has been validated.
Write access to /var/www/html/files/_rss has been validated.
Write access to /var/www/html/files/_sessions has been validated.
Write access to /var/www/html/files/_tmp has been validated.
Write access to /var/www/html/files/_uploads has been validated.
Web access to files directory is protected
exif extension is installed.
ldap extension is installed.
openssl extension is installed.
zip extension is installed.
bz2 extension is installed.
Zend OPcache extension is installed.
Following extensions are installed: ctype, iconv, mbstring, sodium.
Write access to /var/www/html/marketplace has been validated.
Timezones seems loaded in database.

GLPI constants
 
GLPI_ROOT: /var/www/html
GLPI_CONFIG_DIR: /var/www/html/config
GLPI_VAR_DIR: /var/www/html/files
GLPI_MARKETPLACE_DIR: /var/www/html/marketplace
GLPI_USE_CSRF_CHECK: 1
GLPI_CSRF_EXPIRES: 7200
GLPI_CSRF_MAX_TOKENS: 100
GLPI_USE_IDOR_CHECK: 1
GLPI_IDOR_EXPIRES: 7200
GLPI_ALLOW_IFRAME_IN_RICH_TEXT: 
GLPI_TELEMETRY_URI: https://telemetry.glpi-project.org
GLPI_INSTALL_MODE: TARBALL
GLPI_NETWORK_MAIL: glpi@teclib.com
GLPI_NETWORK_SERVICES: https://services.glpi-network.com
GLPI_MARKETPLACE_ALLOW_OVERRIDE: 1
GLPI_MARKETPLACE_MANUAL_DOWNLOADS: 1
GLPI_USER_AGENT_EXTRA_COMMENTS: 
GLPI_DISABLE_ONLY_FULL_GROUP_BY_SQL_MODE: 1
GLPI_AJAX_DASHBOARD: 1
GLPI_CALDAV_IMPORT_STATE: 0
GLPI_DEMO_MODE: 0
GLPI_CENTRAL_WARNINGS: 1
GLPI_DOC_DIR: /var/www/html/files
GLPI_CACHE_DIR: /var/www/html/files/_cache
GLPI_CRON_DIR: /var/www/html/files/_cron
GLPI_DUMP_DIR: /var/www/html/files/_dumps
GLPI_GRAPH_DIR: /var/www/html/files/_graphs
GLPI_LOCAL_I18N_DIR: /var/www/html/files/_locales
GLPI_LOCK_DIR: /var/www/html/files/_lock
GLPI_LOG_DIR: /var/www/html/files/_log
GLPI_PICTURE_DIR: /var/www/html/files/_pictures
GLPI_PLUGIN_DOC_DIR: /var/www/html/files/_plugins
GLPI_RSS_DIR: /var/www/html/files/_rss
GLPI_SESSION_DIR: /var/www/html/files/_sessions
GLPI_TMP_DIR: /var/www/html/files/_tmp
GLPI_UPLOAD_DIR: /var/www/html/files/_uploads
GLPI_INVENTORY_DIR: /var/www/html/files/_inventories
GLPI_NETWORK_REGISTRATION_API_URL: https://services.glpi-network.com/api/registration/
GLPI_MARKETPLACE_PLUGINS_API_URI: https://services.glpi-network.com/api/glpi-plugins/
GLPI_I18N_DIR: /var/www/html/locales
GLPI_VERSION: 10.0.1
GLPI_SCHEMA_VERSION: 10.0.1@a130db99c7d9b131c2e2ea59fe0d6260fe93d831
GLPI_MARKETPLACE_PRERELEASES: 
GLPI_MIN_PHP: 7.4.0
GLPI_MAX_PHP: 8.2.0
GLPI_YEAR: 2022

Libraries
 
htmlawed/htmlawed version 1.2.6 in (/var/www/html/vendor/htmlawed/htmlawed)
phpmailer/phpmailer version 6.6.0 in (/var/www/html/vendor/phpmailer/phpmailer/src)
simplepie/simplepie version 1.5.8 in (/var/www/html/vendor/simplepie/simplepie/library)
tecnickcom/tcpdf version 6.4.4 in (/var/www/html/vendor/tecnickcom/tcpdf)
michelf/php-markdown in (/var/www/html/vendor/michelf/php-markdown/Michelf)
true/punycode in (/var/www/html/vendor/true/punycode/src)
iamcal/lib_autolink in (/var/www/html/vendor/iamcal/lib_autolink)
sabre/dav in (/var/www/html/vendor/sabre/dav/lib/DAV)
sabre/http in (/var/www/html/vendor/sabre/http/lib)
sabre/uri in (/var/www/html/vendor/sabre/uri/lib)
sabre/vobject in (/var/www/html/vendor/sabre/vobject/lib)
laminas/laminas-i18n in (/var/www/html/vendor/laminas/laminas-i18n/src)
laminas/laminas-servicemanager in (/var/www/html/vendor/laminas/laminas-servicemanager/src)
monolog/monolog in (/var/www/html/vendor/monolog/monolog/src/Monolog)
sebastian/diff in (/var/www/html/vendor/sebastian/diff/src)
donatj/phpuseragentparser in (/var/www/html/vendor/donatj/phpuseragentparser/src/UserAgent)
elvanto/litemoji in (/var/www/html/vendor/elvanto/litemoji/src)
symfony/console in (/var/www/html/vendor/symfony/console)
scssphp/scssphp in (/var/www/html/vendor/scssphp/scssphp/src)
laminas/laminas-mail in (/var/www/html/vendor/laminas/laminas-mail/src/Protocol)
laminas/laminas-mime in (/var/www/html/vendor/laminas/laminas-mime/src)
rlanvin/php-rrule in (/var/www/html/vendor/rlanvin/php-rrule/src)
blueimp/jquery-file-upload in (/var/www/html/vendor/blueimp/jquery-file-upload/server/php)
ramsey/uuid in (/var/www/html/vendor/ramsey/uuid/src)
psr/log in (/var/www/html/vendor/psr/log/Psr/Log)
psr/simple-cache in (/var/www/html/vendor/psr/simple-cache/src)
psr/cache in (/var/www/html/vendor/psr/cache/src)
league/csv in (/var/www/html/vendor/league/csv/src)
mexitek/phpcolors in (/var/www/html/vendor/mexitek/phpcolors/src/Mexitek/PHPColors)
guzzlehttp/guzzle in (/var/www/html/vendor/guzzlehttp/guzzle/src)
guzzlehttp/psr7 in (/var/www/html/vendor/guzzlehttp/psr7/src)
glpi-project/inventory_format in (/var/www/html/vendor/glpi-project/inventory_format/lib/php)
wapmorgan/unified-archive in (/var/www/html/vendor/wapmorgan/unified-archive/src)
paragonie/sodium_compat in (/var/www/html/vendor/paragonie/sodium_compat/src)
symfony/cache in (/var/www/html/vendor/symfony/cache)
html2text/html2text in (/var/www/html/vendor/html2text/html2text/src)
symfony/css-selector in (/var/www/html/vendor/symfony/css-selector)
symfony/dom-crawler in (/var/www/html/vendor/symfony/dom-crawler)
twig/twig in (/var/www/html/vendor/twig/twig/src)
twig/string-extra in (/var/www/html/vendor/twig/string-extra)
symfony/polyfill-ctype not found
symfony/polyfill-iconv not found
symfony/polyfill-mbstring not found
symfony/polyfill-php80 in (/var/www/html/vendor/symfony/polyfill-php80)
symfony/polyfill-php81 in (/var/www/html/vendor/symfony/polyfill-php81)
phpCas version 1.3.6 in (/usr/share/php/CAS/source)

LDAP directories
 
Server: 'HU-HUCAM-VP-AD1.ebserhnet.ebserh.gov.br', Port: '389', BaseDN:
        'OU=HUCAM,OU=EBSERH,DC=ebserhnet,DC=ebserh,DC=gov,DC=br', Connection filter:
        '(&(objectClass=user)(objectCategory=person)(!(userAccountControl:1.2.840.113556.1.4.803:=2)))', RootDN:
        'ebserhnet\hucamsrvc.redmine', Use TLS: none

SQL replicas
 
Not active

Notifications
 
Way of sending emails: SMTP (anonymous@localhost)

Plugins list
 
    fields               Name: Campos adicionais              Version: 1.15.3     State: Enabled
    accounts             Name: Contas                         Version: 3.0.2      State: Enabled
    escalade             Name: Escalonamento                  Version: 2.8.0      State: Installed / not activated
    formcreator          Name: Form Creator                   Version: 2.12.5     State: Installed / not activated
    gappessentials       Name: Gapp Essentials                Version: 2.0.0      State: Enabled
    order                Name: Gerenciamento das ordens de co Version: 2.9.0      State: Installed / not activated
    genericobject        Name: Gerenciamento de objetos       Version: 2.12.0     State: Installed / not activated
    glpiinventory        Name: GLPI Inventory                 Version: 1.0.1      State: Enabled
    itilcategorygroups   Name: Grupos ItilCategory            Version: 2.5.0      State: Installed / not activated
    mreporting           Name: Mais Relatórios                Version: 1.8.0      State: Enabled
    consumables          Name: Pedidos de consumíveis         Version: 2.0.0      State: Enabled

Anything else?

No response

trasher commented 2 years ago

You probably have an agent (or more...) listed in your database with a missing itemtype; could you please check that? No idea how this has happened; maybe some other data on wrong line can help to understand.

brunnersm commented 2 years ago

SELECT FROM glpi_agents WHERE itemtype <> 'Computer' / Registros afetados: 0 Registros encontrados: 0 Avisos: 0 Duração de 1 consulta: 0,000 seg. */

trasher commented 2 years ago

This can be a still referenced agent in glpi_plugin_glpiinventory_taskjobstates that has been deleted in agents table.

This looks like a plugin issue, try with:

diff --git a/inc/agentwakeup.class.php b/inc/agentwakeup.class.php
index b0a961a2ae..35df4c5883 100644
--- a/inc/agentwakeup.class.php
+++ b/inc/agentwakeup.class.php
@@ -172,11 +172,12 @@ class PluginGlpiinventoryAgentWakeup extends CommonDBTM
                 if (isset($wakeupArray[$agents_id])) {
                     $counter++;
                 } else {
-                    $agent->getFromDB($agents_id);
-                    $statusAgent = $agent->requestStatus();
-                    if ($statusAgent['answer'] == 'waiting') {
-                        $wakeupArray[$agents_id] = $agents_id;
-                        $counter++;
+                    if ($agent->getFromDB($agents_id)) {
+                        $statusAgent = $agent->requestStatus();
+                        if ($statusAgent['answer'] == 'waiting') {
+                            $wakeupArray[$agents_id] = $agents_id;
+                            $counter++;
+                        }
                     }
                 }
brunnersm commented 2 years ago

Thanks, i run "DELETE FROM glpi_plugin_glpiinventory_taskjobstates WHERE agents_id = 0" and fix the problem. Maybe because it was FusionInventory before

trasher commented 2 years ago

Possible, yes... I close the issue for now; we'll investigate if it appears again then.