fralla2
commented
2 years ago @trasher Do you want me to test the fix on my setup or it's still have some work to do on it before? Thanks Francois
Closed fralla2 closed 2 years ago
fralla2
commented
2 years ago @trasher Do you want me to test the fix on my setup or it's still have some work to do on it before? Thanks Francois
trasher
commented
2 years ago I think you can test on your environment. PR is not apporved yet; but I do not think there will be huge changes ;)
fralla2
commented
2 years ago This looks like it did the trick 👍
Thanks @trasher
fralla2
commented
2 years ago I see the same problem now that GLPI Inventory is activated but on another table :
[2022-10-03 10:25:03] glpisqllog.ERROR: DBmysql::query() in /var/www/html/glpi-10.0.3/src/DBmysql.php line 370
*** MySQL query error:
SQL: INSERT INTO glpi_devicecontrols (designation, manufacturers_id, interfacetypes_id, date_creation, date_mod) VALUES ('H81 Express LPC Controller', 'Intel Corporation', '217', '2022-10-03 10:24:59', '2022-10-03 10:24:59')
Error: Incorrect integer value: 'Intel Corporation' for column 'manufacturers_id' at row 1
Backtrace :
src/DBmysql.php:1312
src/CommonDBTM.php:716 DBmysql->insert()
src/CommonDBTM.php:1321 CommonDBTM->addToDB()
src/CommonDevice.php:512 CommonDBTM->add()
src/Inventory/Asset/Device.php:121 CommonDevice->import()
src/Inventory/Asset/Controller.php:98 Glpi\Inventory\Asset\Device->handle()
src/Inventory/Asset/MainAsset.php:847 Glpi\Inventory\Asset\Controller->handle()
src/Inventory/Asset/MainAsset.php:754 Glpi\Inventory\Asset\MainAsset->handleAssets()
src/RuleImportAsset.php:946 Glpi\Inventory\Asset\MainAsset->rulepassed()
src/Rule.php:1510 RuleImportAsset->executeActions()
src/RuleCollection.php:1591 Rule->process()
src/Inventory/Asset/MainAsset.php:554 RuleCollection->processAllRules()
src/Inventory/Inventory.php:701 Glpi\Inventory\Asset\MainAsset->handle()
src/Inventory/Inventory.php:336 Glpi\Inventory\Inventory->handleItem()
src/Inventory/Request.php:360 Glpi\Inventory\Inventory->doInventory()
src/Inventory/Request.php:90 Glpi\Inventory\Request->inventory()
src/Agent/Communication/AbstractRequest.php:305 Glpi\Inventory\Request->handleAction()
src/Agent/Communication/AbstractRequest.php:242 Glpi\Agent\Communication\AbstractRequest->handleXMLRequest()
front/inventory.php:86 Glpi\Agent\Communication\AbstractRequest->handleRequest()
{"user":"@host","mem_usage":"0.001\", 7.48Mio)"}
trasher
commented
2 years ago Are you sure the fix from the PR is still activated?
fralla2
commented
2 years ago Yes the file src/Inventory/Asset/InventoryAsset.php still contains the fix
trasher
commented
2 years ago Yes the file src/Inventory/Asset/InventoryAsset.php still contains the fix
Well, that's another problem then... I've opened a new issue to investigate; I have no idea right now if I can reproduce or not.
Code of Conduct
Is there an existing issue for this?
Version
10.0.3
Bug description
When having dictionary rule active for manufacturer (might also affect other dictionary rules too), the name is returned instead of the id when trying to import the device in GLPI using native inventory. This throws errors like this one and prevent import of the new device
Error: Incorrect integer value: 'Dell, Inc.' for column 'manufacturers_id' at row 1
Relevant log output
Page URL
No response
Steps To reproduce
Create a dictionary rule for the computer manufacturer like this one :
Try to import the computer to native glpi inventory (this throw a lot of error in the log files related to incorrect integer value
Disable the dictionary rule
Try to import again (works fine)
Note : This was working correctly in GLPI 9.5.7
Your GLPI setup information
Informations sur le système, l'installation et la configuration
Server
Operating system: Linux deimos01 4.18.0-408.el8.x86_64 #1 SMP Mon Jul 18 17:42:52 UTC 2022 x86_64 PHP 8.1.11 fpm-fcgi (Core, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apcu, bcmath, bz2, calendar, cgi-fcgi, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imap, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, pdo_sqlite, posix, session, shmop, soap, sockets, sodium, sqlite3, standard, sysvmsg, sysvsem, sysvshm, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib) Setup: max_execution_time="600" memory_limit="256M" post_max_size="100M" safe_mode="" session.save_handler="files" upload_max_filesize="100M" Software: Apache/2.4.37 (centos) OpenSSL/1.1.1k () Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36 Server Software: Source distribution Server Version: 8.0.26 Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION Parameters: REDACTED Host info: REDACTED via TCP/IP PHP version (8.1.11) is supported. Sessions configuration is OK. Allocated memory is sufficient. mysqli extension is installed. Following extensions are installed: dom, fileinfo, json, simplexml. curl extension is installed. gd extension is installed. intl extension is installed. libxml extension is installed. zlib extension is installed. The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present. Database engine version (8.0.26) is supported. The log file has been created successfully. Write access to /var/www/glpiData/files/_cache has been validated. Write access to /var/www/glpiData/config/ has been validated. Write access to /var/www/glpiData/files/_cron has been validated. Write access to /var/www/glpiData/files has been validated. Write access to /var/www/glpiData/files/_dumps has been validated. Write access to /var/www/glpiData/files/_graphs has been validated. Write access to /var/www/glpiData/files/_lock has been validated. Write access to /var/www/glpiData/files/_pictures has been validated. Write access to /var/www/glpiData/files/_plugins has been validated. Write access to /var/www/glpiData/files/_rss has been validated. Write access to /var/www/glpiData/files/_sessions has been validated. Write access to /var/www/glpiData/files/_tmp has been validated. Write access to /var/www/glpiData/files/_uploads has been validated. For security reasons, SELinux mode should be Enforcing. PHP directive "session.cookie_secure" should be set to "on" when GLPI can be accessed on HTTPS protocol. PHP directive "session.cookie_httponly" should be set to "on" to prevent client-side script to access cookie values. exif extension is installed. ldap extension is installed. openssl extension is installed. zip extension is installed. bz2 extension is installed. Zend OPcache extension is installed. Following extensions are installed: ctype, iconv, mbstring, sodium. Write access to /var/www/html/glpi-10.0.3/marketplace has been validated. Timezones seems loaded in database.GLPI constants
Libraries
REDACTED
SQL replicas
Notifications
Plugins list
advancedplanning Name: advancedplanning Version: 1.1.0 State: Enabled Install Method: Marketplace treeview Name: Arborescence Version: 1.10.0 State: Enabled Install Method: Marketplace fields Name: Champs supplémentaires Version: 1.17.3 State: Enabled Install Method: Marketplace csscvinventorylabels Name: CSSCV Inventory Labels Version: 1.0.1 State: Enabled Install Method: Manual datainjection Name: Data Injection Version: 2.12.0 State: Enabled Install Method: Marketplace formcreator Name: Form Creator Version: 2.13.1 State: Enabled Install Method: Marketplace geninventorynumber Name: Génération de numéros d'invent Version: 2.8.2 State: Enabled Install Method: Marketplace genericobject Name: Gestion d'objets Version: 2.13.0 State: Enabled Install Method: Marketplace order Name: Gestion des commandes Version: 2.9.0 State: Enabled Install Method: Marketplace tag Name: Gestion des tags Version: 2.10.0 State: Enabled Install Method: Marketplace manufacturersimports Name: Imports fabricants Version: 3.0.2 State: Enabled Install Method: Marketplace jamfschool Name: JamfSchool Version: 1.0.1 State: Installed / not activated Install Method: Manual oauthimap Name: Oauth IMAP Version: 1.4.1 State: Enabled Install Method: Marketplace taskdrop Name: TaskDrop Version: 2.0.0 State: Enabled Install Method: MarketplaceAnything else?
No response