glpi-project / glpi

GLPI is a Free Asset and IT Management Software package, Data center management, ITIL Service Desk, licenses tracking and software auditing.
https://glpi-project.org
GNU General Public License v3.0
4.18k stars 1.28k forks source link

when opening a file from documents or from access, it writes an error #13022

Closed NazarovRoman closed 1 year ago

NazarovRoman commented 1 year ago

Code of Conduct

Is there an existing issue for this?

Version

10.0.3

Bug description

PHP Notice (8): iconv(): Detected an illegal character in input string in /opt/glpi/src/Toolbox.php at line 705 PHP Warning (2): Cannot modify header information - headers already sent by (output started at /opt/glpi/src/Application/ErrorHandler.php:535) in /opt/glpi/src/Toolbox.php at line 707 PHP Warning (2): Cannot modify header information - headers already sent by (output started at /opt/glpi/src/Application/ErrorHandler.php:535) in /opt/glpi/src/Toolbox.php at line 709

php-errors.log access-errors.log sql-errors.log

error screen: 2022-10-19_125057 or 2022-10-19_125416 the result is the same 2022-10-19_125248

Relevant log output

No response

Page URL

help.bpmg.kz

Steps To reproduce

No response

Your GLPI setup information

Information about system installation & configuration
GLPI 10.0.3 ( => /opt/glpi)
Installation mode: TARBALL
Current language:en_US

Server
 
Operating system: Linux help.bpmg.kz 3.10.0-1160.66.1.el7.x86_64 #1 SMP Wed May 18 16:02:34 UTC 2022 x86_64
PHP 7.4.30 fpm-fcgi (Core, PDO, PDO_ODBC, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apcu, bcmath, bz2, calendar, cgi-fcgi,
    ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imagick, imap, intl, json, ldap, libxml,
    mbstring, mcrypt, memcache, mysqli, mysqlnd, odbc, openssl, pcre, pdo_mysql, pdo_sqlite, posix, pspell, recode, session, shmop,
    soap, sockets, sodium, sqlite3, standard, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl,
    zip, zlib)
Setup: max_execution_time="600" memory_limit="256M" post_max_size="8M" safe_mode="" session.save_handler="files"
    upload_max_filesize="2M" 
Software: nginx/1.22.0
    Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36
Server Software: Percona Server (GPL), Release 41, Revision da46e5474f9
    Server Version: 5.7.38-41
    Server SQL Mode: STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION
    Parameters: glpiuser@localhost/glpidb
    Host info: Localhost via UNIX socket

PHP version (7.4.30) is supported.
Sessions configuration is OK.
Allocated memory is sufficient.
mysqli extension is installed.
Following extensions are installed: dom, fileinfo, json, simplexml.
curl extension is installed.
gd extension is installed.
intl extension is installed.
libxml extension is installed.
zlib extension is installed.
The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present.
Database engine version (5.7.38) is supported.
The log file has been created successfully.
Write access to /opt/glpi/files/_cache has been validated.
Write access to /opt/glpi/config has been validated.
Write access to /opt/glpi/files/_cron has been validated.
Write access to /opt/glpi/files has been validated.
Write access to /opt/glpi/files/_dumps has been validated.
Write access to /opt/glpi/files/_graphs has been validated.
Write access to /opt/glpi/files/_lock has been validated.
Write access to /opt/glpi/files/_pictures has been validated.
Write access to /opt/glpi/files/_plugins has been validated.
Write access to /opt/glpi/files/_rss has been validated.
Write access to /opt/glpi/files/_sessions has been validated.
Write access to /opt/glpi/files/_tmp has been validated.
Write access to /opt/glpi/files/_uploads has been validated.
Web access to the files directory should not be allowed
Check the .htaccess file and the web server configuration.
For security reasons, SELinux mode should be Enforcing.
PHP directive "session.cookie_secure" should be set to "on" when GLPI can be accessed on HTTPS protocol.
PHP directive "session.cookie_httponly" should be set to "on" to prevent client-side script to access cookie values.
exif extension is installed.
ldap extension is installed.
openssl extension is installed.
zip extension is installed.
bz2 extension is installed.
Zend OPcache extension is installed.
Following extensions are installed: ctype, iconv, mbstring, sodium.
Write access to /opt/glpi/marketplace has been validated.
Timezones seems loaded in database.

GLPI constants
 
GLPI_ROOT: /opt/glpi
GLPI_CONFIG_DIR: /opt/glpi/config
GLPI_VAR_DIR: /opt/glpi/files
GLPI_MARKETPLACE_DIR: /opt/glpi/marketplace
GLPI_USE_CSRF_CHECK: 1
GLPI_CSRF_EXPIRES: 7200
GLPI_CSRF_MAX_TOKENS: 100
GLPI_USE_IDOR_CHECK: 1
GLPI_IDOR_EXPIRES: 7200
GLPI_ALLOW_IFRAME_IN_RICH_TEXT: 

PHP Notice (8): Array to string conversion in /opt/glpi/src/Config.php at line 2073
GLPI_SERVERSIDE_URL_ALLOWLIST: Array
GLPI_TELEMETRY_URI: https://telemetry.glpi-project.org
GLPI_INSTALL_MODE: TARBALL
GLPI_NETWORK_MAIL: glpi@teclib.com
GLPI_NETWORK_SERVICES: https://services.glpi-network.com
GLPI_MARKETPLACE_ALLOW_OVERRIDE: 1
GLPI_MARKETPLACE_MANUAL_DOWNLOADS: 1
GLPI_USER_AGENT_EXTRA_COMMENTS: 
GLPI_DISABLE_ONLY_FULL_GROUP_BY_SQL_MODE: 1
GLPI_AJAX_DASHBOARD: 1
GLPI_CALDAV_IMPORT_STATE: 0
GLPI_DEMO_MODE: 0
GLPI_CENTRAL_WARNINGS: 1
GLPI_DOC_DIR: /opt/glpi/files
GLPI_CACHE_DIR: /opt/glpi/files/_cache
GLPI_CRON_DIR: /opt/glpi/files/_cron
GLPI_DUMP_DIR: /opt/glpi/files/_dumps
GLPI_GRAPH_DIR: /opt/glpi/files/_graphs
GLPI_LOCAL_I18N_DIR: /opt/glpi/files/_locales
GLPI_LOCK_DIR: /opt/glpi/files/_lock
GLPI_LOG_DIR: /opt/glpi/files/_log
GLPI_PICTURE_DIR: /opt/glpi/files/_pictures
GLPI_PLUGIN_DOC_DIR: /opt/glpi/files/_plugins
GLPI_RSS_DIR: /opt/glpi/files/_rss
GLPI_SESSION_DIR: /opt/glpi/files/_sessions
GLPI_TMP_DIR: /opt/glpi/files/_tmp
GLPI_UPLOAD_DIR: /opt/glpi/files/_uploads
GLPI_INVENTORY_DIR: /opt/glpi/files/_inventories
GLPI_NETWORK_REGISTRATION_API_URL: https://services.glpi-network.com/api/registration/
GLPI_MARKETPLACE_PLUGINS_API_URI: https://services.glpi-network.com/api/glpi-plugins/
GLPI_I18N_DIR: /opt/glpi/locales
GLPI_VERSION: 10.0.3
GLPI_SCHEMA_VERSION: 10.0.3@a130db99c7d9b131c2e2ea59fe0d6260fe93d831
GLPI_MARKETPLACE_PRERELEASES: 
GLPI_MIN_PHP: 7.4.0
GLPI_MAX_PHP: 8.3.0
GLPI_YEAR: 2022

Libraries
 
htmlawed/htmlawed version 1.2.9 in (/opt/glpi/vendor/htmlawed/htmlawed)
phpmailer/phpmailer version 6.6.0 in (/opt/glpi/vendor/phpmailer/phpmailer/src)
simplepie/simplepie version 1.5.8 in (/opt/glpi/vendor/simplepie/simplepie/library)
tecnickcom/tcpdf version 6.4.4 in (/opt/glpi/marketplace/financialreports/vendor/tecnickcom/tcpdf)
michelf/php-markdown in (/opt/glpi/vendor/michelf/php-markdown/Michelf)
true/punycode in (/opt/glpi/vendor/true/punycode/src)
iamcal/lib_autolink in (/opt/glpi/vendor/iamcal/lib_autolink)
sabre/dav in (/opt/glpi/vendor/sabre/dav/lib/DAV)
sabre/http in (/opt/glpi/vendor/sabre/http/lib)
sabre/uri in (/opt/glpi/vendor/sabre/uri/lib)
sabre/vobject in (/opt/glpi/vendor/sabre/vobject/lib)
laminas/laminas-i18n in (/opt/glpi/vendor/laminas/laminas-i18n/src)
laminas/laminas-servicemanager in (/opt/glpi/vendor/laminas/laminas-servicemanager/src)
monolog/monolog in (/opt/glpi/vendor/monolog/monolog/src/Monolog)
sebastian/diff in (/opt/glpi/vendor/sebastian/diff/src)
donatj/phpuseragentparser in (/opt/glpi/vendor/donatj/phpuseragentparser/src/UserAgent)
elvanto/litemoji in (/opt/glpi/vendor/elvanto/litemoji/src)
symfony/console in (/opt/glpi/vendor/symfony/console)
scssphp/scssphp in (/opt/glpi/vendor/scssphp/scssphp/src)
laminas/laminas-mail in (/opt/glpi/vendor/laminas/laminas-mail/src/Protocol)
laminas/laminas-mime in (/opt/glpi/vendor/laminas/laminas-mime/src)
rlanvin/php-rrule in (/opt/glpi/vendor/rlanvin/php-rrule/src)
blueimp/jquery-file-upload in (/opt/glpi/vendor/blueimp/jquery-file-upload/server/php)
ramsey/uuid in (/opt/glpi/vendor/ramsey/uuid/src)
psr/log in (/opt/glpi/vendor/psr/log/Psr/Log)
psr/simple-cache in (/opt/glpi/vendor/psr/simple-cache/src)
psr/cache in (/opt/glpi/vendor/psr/cache/src)
league/csv in (/opt/glpi/vendor/league/csv/src)
mexitek/phpcolors in (/opt/glpi/vendor/mexitek/phpcolors/src/Mexitek/PHPColors)
guzzlehttp/guzzle in (/opt/glpi/vendor/guzzlehttp/guzzle/src)
guzzlehttp/psr7 in (/opt/glpi/vendor/guzzlehttp/psr7/src)
glpi-project/inventory_format in (/opt/glpi/vendor/glpi-project/inventory_format/lib/php)
wapmorgan/unified-archive in (/opt/glpi/vendor/wapmorgan/unified-archive/src)
paragonie/sodium_compat in (/opt/glpi/vendor/paragonie/sodium_compat/src)
symfony/cache in (/opt/glpi/vendor/symfony/cache)
html2text/html2text in (/opt/glpi/vendor/html2text/html2text/src)
symfony/css-selector in (/opt/glpi/vendor/symfony/css-selector)
symfony/dom-crawler in (/opt/glpi/vendor/symfony/dom-crawler)
twig/twig in (/opt/glpi/vendor/twig/twig/src)
twig/string-extra in (/opt/glpi/vendor/twig/string-extra)
symfony/polyfill-ctype not found
symfony/polyfill-iconv not found
symfony/polyfill-mbstring not found
symfony/polyfill-php80 in (/opt/glpi/vendor/symfony/polyfill-php80)
symfony/polyfill-php81 in (/opt/glpi/vendor/symfony/polyfill-php81)
symfony/polyfill-php82 in (/opt/glpi/vendor/symfony/polyfill-php82)
phpCas version 1.3.9 in (/usr/share/pear)

SQL replicas
 
Not active

Notifications
 
Way of sending emails: SMTP+SSL (help@bpmg.kz@smtp.bpmg.kz)

Plugins list
 
    activity             Name: Activities                     Version: 3.1.2      State: Installed / not activated               
        Install Method: Marketplace
    advancedplanning     Name: advancedplanning               Version: 1.1.0      State: Installed / not activated               
        Install Method: Marketplace
    archisw              Name: Apps structures                Version: 2.2.12     State: Enabled                                 
        Install Method: Marketplace
    badges               Name: Badges                         Version: 3.0.0      State: Enabled                                 
        Install Method: Marketplace
    barcode              Name: Barcode                        Version: 2.7.1      State: Enabled                                 
        Install Method: Marketplace
    camerainput          Name: Camera Input                   Version: 2.0.0      State: Installed / not activated               
        Install Method: Marketplace
    connections          Name: Connections                    Version: 10.0.0     State: Enabled                                 
        Install Method: Marketplace
    costs                Name: Costs                          Version: 3.0.1      State: Enabled                                 
        Install Method: Marketplace
    credit               Name: Credit vouchers                Version: 1.11.2     State: Installed / not activated               
        Install Method: Marketplace
    archidata            Name: Data structures                Version: 1.0.10     State: Enabled                                 
        Install Method: Marketplace
    archimap             Name: Diagrams                       Version: 3.2.9      State: Installed / not activated               
        Install Method: Marketplace
    manageentities       Name: Entities portal                Version: 4.0.3      State: Enabled                                 
        Install Method: Marketplace
    formcreator          Name: Form Creator                   Version: 2.13.1     State: Enabled                                 
        Install Method: Marketplace
    glpiinventory        Name: GLPI Inventory                 Version: 1.0.4      State: Installed / not activated               
        Install Method: Marketplace
    geninventorynumber   Name: Inventory number generation    Version: 2.8.3      State: Installed / not activated               
        Install Method: Marketplace
    addressing           Name: IP Adressing                   Version: 3.0.1      State: Enabled                                 
        Install Method: Marketplace
    uninstall            Name: Item's Lifecycle (uninstall)   Version: 2.8.0      State: Enabled                                 
        Install Method: Marketplace
    metademands          Name: Meta-Demands                   Version: 3.2.3      State: Installed / not activated               
        Install Method: Marketplace
    mydashboard          Name: My Dashboard                   Version: 2.0.7      State: Installed / not activated               
        Install Method: Marketplace
    purchaserequest      Name: Purchase request               Version: 3.0.1      State: Enabled                                 
        Install Method: Marketplace
    releases             Name: Releases                       Version: 2.0.3      State: Enabled                                 
        Install Method: Marketplace
    taskdrop             Name: TaskDrop                       Version: 2.0.0      State: Installed / not activated               
        Install Method: Marketplace
    useditemsexport      Name: Used items export              Version: 2.5.1      State: Enabled                                 
        Install Method: Marketplace
    webresources         Name: Web Resources                  Version: 2.0.2      State: Installed / not activated               
        Install Method: Marketplace
    accounts             Name: Аккаунты                       Version: 3.0.2      State: Enabled                           
              Install Method: Marketplace
    webapplications      Name: Веб-приложений              Version: 4.0.1      State: Enabled                         
                Install Method: Marketplace
    itilcategorygroups   Name: Группы ITIL Категории     Version: 2.5.1      State: Installed / not activated       
                Install Method: Marketplace
    fields               Name: Дополнительные поля    Version: 1.18.0     State: Enabled                         
                Install Method: Marketplace
    additionalalerts     Name: Другие уведомления      Version: 2.4.0      State: Enabled                         
                Install Method: Marketplace
    moreticket           Name: Еще заявка                     Version: 1.7.1      State: Enabled                          
               Install Method: Marketplace
    consumables          Name: Заказ расходных материалов Version: 2.0.0      State: Enabled               
                          Install Method: Marketplace
    manufacturersimports Name: Импорт поставщиков      Version: 3.0.2      State: Installed / not activated       
                Install Method: Marketplace
    positions            Name: Картография                   Version: 6.0.1      State: Installed / not activated       
                Install Method: Marketplace
    news                 Name: Оповещения                     Version: 1.10.5     State: Enabled                         
                Install Method: Marketplace
    escalade             Name: Переназначение             Version: 2.8.0      State: Enabled                         
                Install Method: Marketplace
    mreporting           Name: Подробные отчеты          Version: 1.8.2      State: Installed / not activated       
                Install Method: Marketplace
    screenshot           Name: Сделать и приложить снимок экр Version: 2.0.1      State: Enabled         
                                Install Method: Marketplace
    shellcommands        Name: Служебные команды        Version: 4.0.1      State: Enabled                         
                Install Method: Marketplace
    financialreports     Name: Состояния оборудования Version: 3.0.0      State: Enabled                      
                   Install Method: Marketplace
    tasklists            Name: Список задач                  Version: 2.0.2      State: Enabled                         
                Install Method: Marketplace
    timelineticket       Name: Сроки заявок                  Version: 10.0+1.0   State: Enabled                         
                Install Method: Marketplace
    order                Name: Управление заказами    Version: 2.10.0     State: Enabled                         
                Install Method: Marketplace
    genericobject        Name: Управление объектами  Version: 2.14.0     State: Enabled                         
                Install Method: Marketplace
    resources            Name: Человеческие Ресурсы  Version: 3.0.4      State: Installed / not activated       
                Install Method: Marketplace

Anything else?

No response

cedric-anne commented 1 year ago

Hi,

Can you try following patch?

diff --git a/src/Toolbox.php b/src/Toolbox.php
index bf1c7b4d76..e1ee3d690d 100644
--- a/src/Toolbox.php
+++ b/src/Toolbox.php
@@ -712,7 +712,7 @@ class Toolbox
         }
         header(
             "Content-disposition:$attachment filename=\"" .
-            addslashes(iconv('UTF-8', 'ISO-8859-1', $filename)) .
+            addslashes(mb_convert_encoding($filename, 'ISO-8859-1', 'UTF-8')) .
             "\"; filename*=utf-8''" .
             rawurlencode($filename)
         );
NazarovRoman commented 1 year ago

I confirm! It worked!

NazarovRoman commented 1 year ago

unfortunately there was a new error when opening the downloaded file

Microsoft Word

Unfortunately, the file *.doсx cannot be opened due to problems with its contents. OK l Information < << \ Intelligence The file is corrupted so you won't be able to open it.

2022-10-19_135856

cedric-anne commented 1 year ago

Maybe related to #12802 + #12856.

NazarovRoman commented 1 year ago

I did it, it didn't help

cedric-anne commented 1 year ago

First issue will be fixed by #13023 and corrupted file is a different issue. Could you please open a new thread ?

NazarovRoman commented 1 year ago

Oh sure