Closed vollkommenIrrelevant closed 2 years ago
vollkommenIrrelevant
commented
2 years ago @trasher
1. all ports having the same MAC address (nothing we can do about it)We need an inventory file to reproduce and handle the case (if that cause an issue in glpi).
https://github.com/glpi-project/glpi/issues/13094#issuecomment-1326595917, search for e0:07:1b:4e:68:12 in the file.
trasher
commented
2 years ago OK, but I do not see what the problem is. Also, as you said, there is nothing we can do about it.
Anyways, I'm still not able to reproduce the initial reported issue.
po1vo
commented
2 years ago OK, but I do not see what the problem is. Also, as you said, there is nothing we can do about it.
Anyways, I'm still not able to reproduce the initial reported issue.
Way to reproduce:
STRICT_ALL_TABLES is set in sql_mode (SET GLOBAL sql_mode = ...)diff --git a/tests/functionnal/Glpi/Inventory/Assets/NetworkEquipment.php b/tests/functionnal/Glpi/Inventory/Assets/NetworkEquipment.php
index 40407d329f..0d144fd315 100644
--- a/tests/functionnal/Glpi/Inventory/Assets/NetworkEquipment.php
+++ b/tests/functionnal/Glpi/Inventory/Assets/NetworkEquipment.php
@@ -336,7 +336,7 @@ Compiled Mon 23-Jul-12 13:22 by prod_rel_team</COMMENTS>
<CONNECTIONS>
<CDP>1</CDP>
<CONNECTION>
- <IFNUMBER>22</IFNUMBER>
+ <IFNUMBER>E0-07-1B-4E-68-12</IFNUMBER>
<SYSMAC>00:24:b5:bd:c8:01</SYSMAC>
</CONNECTION>
</CONNECTIONS>3. inventory_format not enforcing data type:Not sure I understand. With an "integer" type as it's currently set, file won't validate if you put a string. I'd be surprised if a mac as logical number is really converted, I guess XML converter casts or drop it. Anyways this is not a case we've already seen; and since no inventory file has been provided, no tests has been done.
That's right, the file shouldn't validate. And as it's passed anyway, the DB throws warnings as it gets strings instead of numbers.
trasher
commented
2 years ago 2. Make sure `STRICT_ALL_TABLES` is set in `sql_mode` (SET GLOBAL sql_mode = ...)
That does not seems a good idea to do that.
Anyways, on the validation part, this should not be allowed; I'll test if that fails.
trasher
commented
2 years ago Anyways, on the validation part, this should not be allowed; I'll test if that fails.
Results of my tests (on current GLPI 10 nightly build):
Of course, MAC to integer conversion is not expected at all and can cause difficult to understand issues. I'll take an eye.
Code of Conduct
Is there an existing issue for this?
Version
1.0.3
Bug description
I have a lot errors in sql-errors.log. Is anybody having an Idea how to handle this errors?
Relevant log output
Page URL
No response
Steps To reproduce
No response
Your GLPI setup information
Informationen über das System, die Installation und die Konfiguration
Server
Operating system: Linux glpi 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 PHP 7.4.3 apache2handler (Core, FFI, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, apc, apcu, bcmath, bz2, calendar, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imap, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, posix, readline, session, shmop, sockets, sodium, standard, sysvmsg, sysvsem, sysvshm, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib) Setup: max_execution_time="600" memory_limit="1024M" post_max_size="32M" safe_mode="" session.save_handler="files" upload_max_filesize="32M" Software: Apache/2.4.41 (Ubuntu) (Apache/2.4.41 (Ubuntu) Server at X.Y.lu Port 80 ) Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Server Software: (Ubuntu) Server Version: 8.0.31-0ubuntu0.20.04.1 Server SQL Mode: STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION Parameters: X@localhost/glpi Host info: Localhost via UNIX socket PHP version (7.4.3) is supported. Sessions configuration is OK. Allocated memory is sufficient. mysqli extension is installed. Following extensions are installed: dom, fileinfo, json, simplexml. curl extension is installed. gd extension is installed. intl extension is installed. libxml extension is installed. zlib extension is installed. The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present. Database engine version (8.0.31) is supported. The log file could not be created in /var/www/glpi/files/_log. Write access to /var/www/glpi/files/_cache has been validated. Write access to /var/www/glpi/config has been validated. Write access to /var/www/glpi/files/_cron has been validated. Write access to /var/www/glpi/files has been validated. Write access to /var/www/glpi/files/_dumps has been validated. Write access to /var/www/glpi/files/_graphs has been validated. Write access to /var/www/glpi/files/_lock has been validated. Write access to /var/www/glpi/files/_pictures has been validated. Write access to /var/www/glpi/files/_plugins has been validated. Write access to /var/www/glpi/files/_rss has been validated. Write access to /var/www/glpi/files/_sessions has been validated. Write access to /var/www/glpi/files/_tmp has been validated. Write access to /var/www/glpi/files/_uploads has been validated. Web access to files directory is protected PHP directive "session.cookie_httponly" should be set to "on" to prevent client-side script to access cookie values. exif extension is installed. ldap extension is installed. openssl extension is installed. zip extension is installed. bz2 extension is installed. Zend OPcache extension is installed. Following extensions are installed: ctype, iconv, mbstring, sodium. Write access to /var/www/glpi/marketplace has been validated. Timezones seems loaded in database.GLPI constants
Libraries
LDAP directories
Server: 'X', Port: '389', BaseDN: 'dc=X,dc=local', Connection filter: '(&(objectClass=user)(objectCategory=person)(!(userAccountControl:1.2.840.113556.1.4.803:=2))(memberof=cn=app_glpi,ou=groups,ou=X,dc=X,dc=local))', RootDN: 'X@X.local', Use TLS: noneSQL replicas
Notifications
Plugins list
fields Name: Additional fields Version: 1.18.2 State: Enabled Install Method: Marketplace datainjection Name: Data injection Version: 2.12.0 State: Installed / not activated Install Method: Marketplace glpiinventory Name: GLPI Inventory Version: 1.0.4 State: Enabled Install Method: Marketplace uninstall Name: Item's Lifecycle (uninstall) Version: 2.8.0 State: Enabled Install Method: Marketplace satisfaction Name: More satisfaction Version: 1.6.1 State: Error / to clean Install Method: Manual genericobject Name: Objects management Version: 2.14.0 State: Enabled Install Method: Marketplace printlabel Name: Print Label Version: 0.0.1 State: Enabled Install Method: Manual printlabelprinter Name: Print Label Printer Version: 0.0.1 State: Enabled Install Method: Manual printercounters Name: Printer counters Version: 2.0.0 State: Error / to clean Install Method: ManualAnything else?
No response