glpi-project / glpi

GLPI is a Free Asset and IT Management Software package, Data center management, ITIL Service Desk, licenses tracking and software auditing.
https://glpi-project.org
GNU General Public License v3.0
4.1k stars 1.27k forks source link

Contract Renewal and Notice - miscalculated #14703

Open Christof48 opened 1 year ago

Christof48 commented 1 year ago

Code of Conduct

Is there an existing issue for this?

Version

10.0.0.6

Bug description

Contract renewal is working unexpected. If I have "initial Contract period" 60 month and "contract renewal" is additional 12 Month I don`t get 70 moth but 120 month at first renewal. Also Notice gives unexpected Results and does not calculate correct.

Relevant log output

No response

Page URL

No response

Steps To reproduce

No response

Your GLPI setup information

GLPI 10.0.6 ( => /usr/share/glpi) Installation mode: RPM Current language:en_GB

Anything else?

GLPI Contracts

Christof48 commented 1 year ago

Server:

Operating system: Linux yp-glpi.rheine 5.12.15-300.fc34.x86_64 #1 SMP Wed Jul 7 19:46:50 UTC 2021 x86_64 PHP 8.0.8 fpm-fcgi (Core, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apcu, bcmath, bz2, calendar, cgi-fcgi, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imagick, imap, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, pdo_sqlite, posix, session, shmop, snmp, sockets, sodium, sqlite3, standard, sysvmsg, sysvsem, sysvshm, tidy, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib) Setup: max_execution_time="60" memory_limit="2048M" post_max_size="22M" safe_mode="" session.save_handler="files" upload_max_filesize="22M" Software: Apache/2.4.48 (Fedora) () Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/113.0 Server Software: MariaDB Server Server Version: 10.5.11-MariaDB Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION Parameters: root@localhost/glpi Host info: Localhost via UNIX socket

PHP version (8.0.8) is supported.PHP version (8.0.8) is supported. Sessions configuration is OK.Sessions configuration is OK. Allocated memory is sufficient.Allocated memory is sufficient. mysqli extension is installed.mysqli extension is installed. Following extensions are installed: dom, fileinfo, json, simplexml.Following extensions are installed: dom, fileinfo, json, simplexml. curl extension is installed.curl extension is installed. gd extension is installed.gd extension is installed. intl extension is installed.intl extension is installed. libxml extension is installed.libxml extension is installed. zlib extension is installed.zlib extension is installed. The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present.The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present. Database engine version (10.5.11) is supported.Database engine version (10.5.11) is supported. No files from previous GLPI version detected.No files from previous GLPI version detected. The log file has been created successfully.The log file has been created successfully. Write access to /var/lib/glpi/files/_cache has been validated. Write access to /etc/glpi has been validated. Write access to /var/lib/glpi/files/_cron has been validated. Write access to /var/lib/glpi/files has been validated. Write access to /var/lib/glpi/files/_dumps has been validated. Write access to /var/lib/glpi/files/_graphs has been validated. Write access to /var/lib/glpi/files/_lock has been validated. Write access to /var/lib/glpi/files/_pictures has been validated. Write access to /var/lib/glpi/files/_plugins has been validated. Write access to /var/lib/glpi/files/_rss has been validated. Write access to /var/lib/glpi/files/_sessions has been validated. Write access to /var/lib/glpi/files/_tmp has been validated. Write access to /var/lib/glpi/files/_uploads has been validated.Write access to /var/lib/glpi/files/_cache has been validated. Write access to /etc/glpi has been validated. Write access to /var/lib/glpi/files/_cron has been validated. Write access to /var/lib/glpi/files has been validated. Write access to /var/lib/glpi/files/_dumps has been validated. Write access to /var/lib/glpi/files/_graphs has been validated. Write access to /var/lib/glpi/files/_lock has been validated. Write access to /var/lib/glpi/files/_pictures has been validated. Write access to /var/lib/glpi/files/_plugins has been validated. Write access to /var/lib/glpi/files/_rss has been validated. Write access to /var/lib/glpi/files/_sessions has been validated. Write access to /var/lib/glpi/files/_tmp has been validated. Write access to /var/lib/glpi/files/_uploads has been validated. GLPI data directories are located in a secured path.GLPI data directories are located in a secured path. For security reasons, SELinux mode should be Enforcing.For security reasons, SELinux mode should be Enforcing. PHP directive "session.cookie_httponly" should be set to "on" to prevent client-side script to access cookie values.PHP directive "session.cookie_httponly" should be set to "on" to prevent client-side script to access cookie values. exif extension is installed.exif extension is installed. ldap extension is installed.ldap extension is installed. openssl extension is installed.openssl extension is installed. zip extension is installed.zip extension is installed. bz2 extension is installed.bz2 extension is installed. Zend OPcache extension is installed.Zend OPcache extension is installed. Following extensions are installed: ctype, iconv, mbstring, sodium.Following extensions are installed: ctype, iconv, mbstring, sodium. Write access to /usr/share/glpi/marketplace has been validated.Write access to /usr/share/glpi/marketplace has been validated. Timezones seems loaded in database.Timezones seems loaded in database.

Christof48 commented 1 year ago

order Name: Bestellverwaltung Version: 2.10.3 State: Enabled
Install Method: Marketplace datainjection Name: Data injection Version: 2.13.0 State: Enabled
Install Method: Marketplace moreticket Name: More ticket Version: 1.7.1 State: Not installed
Install Method: Marketplace genericobject Name: Objects management Version: 2.14.2 State: Enabled
Install Method: Marketplace yagp Name: yagp Version: 2.1.1 State: Enabled
Install Method: Marketplace

cedric-anne commented 1 year ago

Hi,

I confirm the issue. The renewal logic introduced in commit e07870c0ec3cbf81b6bc2126b03ad8695837b05c is based on initial duration instead of renewal period.

M-Falken commented 10 months ago

hi, any news on this one please ?

Christof48 commented 10 months ago

Sorry, nothing changed

Von: Grégory Roussel @.> Gesendet: Montag, 30. Oktober 2023 09:33 An: glpi-project/glpi @.> Cc: Christof48 @.>; Author @.> Betreff: Re: [glpi-project/glpi] Contract Renewal and Notice - miscalculated (Issue #14703)

hi, any news on this one please ?

— Reply to this email directly, view it on GitHub https://github.com/glpi-project/glpi/issues/14703#issuecomment-1784712216 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ASDXPY7IKEVHD5VWOYBTRNTYB5Q5TAVCNFSM6AAAAAAX7HEJJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUG4YTEMRRGY . You are receiving this because you authored the thread. https://github.com/notifications/beacon/ASDXPYZEXKENSCDIRIO6CHDYB5Q5TA5CNFSM6AAAAAAX7HEJJKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTKMCGBQ.gif Message ID: @. @.> >

FreeMacs commented 7 months ago

Is there any new information? We have the same problem as you can see in my Ticket #15893. We would like to use the function in our company but unfortunately this is not possible with the bug.

blippercop commented 6 months ago

Any update? Contracts are associated with financial aspects - will this impact notification about contract expirations, or is this only a "visible thing"?