Closed laszlokertesz closed 7 months ago
cconard96
commented
8 months ago By default, the description property in the inventory data is written to the comments. As of GLPI 10.0.12, you should be able to lock this field to prevent it from being overwritten by inventory data (this only blocks automatic changes. manually changing this field would still work).
Administration > Inventory, click "Add global lock" button along the top of the page.
laszlokertesz
commented
8 months ago I looked at that, but there doesn't seem to be an entry for "Computer - Comments", everything else seem to be there.
laszlokertesz
commented
8 months ago By default, the
descriptionproperty in the inventory data is written to the comments.
But if there was something in the comments, why does it overwrites it. We had all kinds of information there, physical inventory dates, previous users etc. Yes most of these can be obtained but it needs looking into logs etc but we use it for quick information lookup, it can be put directly in the filter lists.
The information placed in the comments are meaningless for us and probably to most users that expect that field to be preserved. Maybe the comments should be preserved and these information added instead of deleting the previous ones?
laszlokertesz
commented
8 months ago I looked at that, but there doesn't seem to be an entry for "Computer - Comments", everything else seem to be there.
Hmm i did a html inspection and the entry names "Computer - Location comments has the description of "Computer - comment" in the code. I added that field, let's see what happens.
trasher
commented
8 months ago Maybe the comments should be preserved and these information added instead of deleting the previous ones?
In a normal flow, inventory creates a computer, then you edit the comment. When editing manually, comment field is locked, inventory will not change it again. If comment field is not locked for any reason (for example you create computer manually first and then it's updated from inventory); adding a global lock on comment field is the way to go.
AldarisPale
commented
8 months ago @laszlokertesz - please check https://github.com/glpi-project/glpi/issues/16256 for more background. The bad news here is that whatever you had on the comment fields before probably still exists somewhere in the database, but it's not being shown in the UI: https://github.com/glpi-project/glpi/issues/16257
github-actions[bot]
commented
7 months ago This issue has been closed as we only track bugs here.
You can get community support on forums or you can consider taking a subscription to get professional support. You can also contact GLPI editor team directly.
Code of Conduct
Is there an existing issue for this?
Version
10.0.12
Bug description
After upgrading to Glpi 10.0.12 (and glpi inventory plugin to 1.3.4) , most of the macs we have had their comments overwritten by the arch of the cpu and a numbr (i assume some id somewhere) lke
The logs show something like this:
Most of the macs had previous comments there. Why is this happening, what is the reason behind this?
Relevant log output
No response
Page URL
No response
Steps To reproduce
We just upgraded the server, most macs that reported after that time got this treatment.
Your GLPI setup information
Information about system installation and configuration
Server
Operating system: Linux inventory.3pillarglobal.com 6.1.0-18-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.76-1 (2024-02-01) x86_64 PHP 8.2.7 apache2handler (Core, FFI, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, apcu, bz2, calendar, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imap, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, posix, random, readline, session, shmop, sockets, sodium, ssh2, standard, sysvmsg, sysvsem, sysvshm, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib) Setup: max_execution_time="30" memory_limit="256M" post_max_size="8M" safe_mode="" session.save_handler="files" upload_max_filesize="2M" disable_functions="" Software: Apache () Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0 Server Software: Debian 12 Server Version: 10.11.6-MariaDB-0+deb12u1 Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION Parameters: root@localhost/glpi Host info: Localhost via UNIX socket PHP version (8.2.7) is supported. Sessions configuration is OK. Allocated memory is sufficient. mysqli extension is installed. Following extensions are installed: dom, fileinfo, filter, libxml, json, simplexml, xmlreader, xmlwriter. curl extension is installed. gd extension is installed. intl extension is installed. zlib extension is installed. The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present. Database engine version (10.11.6) is supported. No files from previous GLPI version detected. The log file has been created successfully. Write access to /var/www/html/glpi/files/_cache has been validated. Write access to /var/www/html/glpi/files/_cron has been validated. Write access to /var/www/html/glpi/files has been validated. Write access to /var/www/html/glpi/files/_dumps has been validated. Write access to /var/www/html/glpi/files/_graphs has been validated. Write access to /var/www/html/glpi/files/_lock has been validated. Write access to /var/www/html/glpi/files/_pictures has been validated. Write access to /var/www/html/glpi/files/_plugins has been validated. Write access to /var/www/html/glpi/files/_rss has been validated. Write access to /var/www/html/glpi/files/_sessions has been validated. Write access to /var/www/html/glpi/files/_tmp has been validated. Write access to /var/www/html/glpi/files/_uploads has been validated. Web server root directory configuration seems safe. PHP directive "session.cookie_secure" should be set to "on" when GLPI can be accessed on HTTPS protocol. PHP directive "session.cookie_httponly" should be set to "on" to prevent client-side script to access cookie values. OS and PHP are relying on 64 bits integers. exif extension is installed. ldap extension is installed. openssl extension is installed. Following extensions are installed: bz2, Phar, zip. Zend OPcache extension is installed. Following extensions are installed: ctype, iconv, mbstring, sodium. Write access to /var/www/html/glpi/marketplace has been validated. Timezones seems loaded in database.GLPI constants
Libraries
LDAP directories
Server: 'ldaps://1.1.1.1', Port: '636', BaseDN: 'DC=domain,DC=corp', Connection filter: '(&(objectClass=user)(objectCategory=person)(!(userAccountControl:1.2.840.113556.1.4.803:=2)))', RootDN: 'CN=Glpi Auth,OU=AD,OU=ServiceAccounts,OU=AllUsers,DC=3pillar,DC=corp', Use TLS: none Server: 'localhost', Port: '1636', BaseDN: 'DC=domain,DC=com', Connection filter: none, RootDN: 'OptimalGre', Use TLS: noneSQL replicas
Notifications
Plugins list
glpiinventory Name: GLPI Inventory Version: 1.3.4 State: Enabled Install Method: Manual phpsaml Name: PHP SAML Version: 1.3.0 State: Enabled Install Method: ManualAnything else?
No response