search

glpi-project / glpi

GLPI is a Free Asset and IT Management Software package, Data center management, ITIL Service Desk, licenses tracking and software auditing.
https://glpi-project.org
GNU General Public License v3.0
4.14k stars 1.28k forks source link

Watcher group cannot add followup, although "ADD FOLLOWUP (ASSOCIATED GROUPS)" permission is set #16833

Open AldarisPale opened 6 months ago

AldarisPale commented 6 months ago

Code of Conduct

Is there an existing issue for this?

Version

10.0.12

Bug description

When a person belongs to a group which is added as a watcher to a ticket, and the profile has "ADD FOLLOWUP (ASSOCIATED GROUPS)" checkbox marked, they cannot add followup to a ticket.

Relevant log output

N/A

Page URL

front/ticket.form.php

Steps To reproduce

  1. Have self-service profile defined
  2. Self-service profile has ADD FOLLOWUP (ASSOCIATED GROUPS) permission
  3. Define a group named test_group_1
  4. Add test_user_1 to this group
  5. Create a ticket
  6. Add test_group_1 as watcher to ticket
  7. Login is as test_user_1
  8. Open the created ticket
  9. Observe that there's now Answer/Followup button

Your GLPI setup information

GLPI 10.0.12 ( => /var/www) Installation mode: TARBALL Current language:en_GB Plugins list fields Name: Additional fields Version: 1.21.6 State: Enabled glpiinventory Name: GLPI Inventory Version: 1.3.4 State: Enabled genericobject Name: Objects management Version: 2.14.8 State: Enabled

Anything else?

No response

trasher commented 6 months ago

10.0.12 is outdated. Try if you reproduce with latest release. Also try with no plugin.

AldarisPale commented 6 months ago

@trasher can reproduce with stock pluginless GLPI 10.0.14. image

The profile for post-only user (self-service): image

github-actions[bot] commented 3 months ago

There has been no activity on this issue for some time and therefore it is considered stale and will be closed automatically in 10 days.

If this issue is related to a bug, please try to reproduce on latest release. If the problem persist, feel free to add a comment to revive this issue. If it is related to a new feature, please open a topic to discuss with community about this enhancement on suggestion website.

You may also consider taking a subscription to get professionnal support or contact GLPI editor team directly.

AldarisPale commented 3 months ago

Problem still exists

github-actions[bot] commented 1 month ago

There has been no activity on this issue for some time and therefore it is considered stale and will be closed automatically in 10 days.

If this issue is related to a bug, please try to reproduce on latest release. If the problem persist, feel free to add a comment to revive this issue. If it is related to a new feature, please open a topic to discuss with community about this enhancement on suggestion website.

You may also consider taking a subscription to get professionnal support or contact GLPI editor team directly.

AldarisPale commented 1 month ago

Posting here to prevent auto-closure of ticket, as problem still persists.

cconard96 commented 1 month ago

"Add Followup (Associated groups)" only applies to requesters and the permission to add followups as an observer only applies when the user is directly assigned as an observer. In my opinion it is not a bug. If this behavior is to be changed, we need to decide what the most logical behavior would be.

Would "Add Followup (Associated groups)" apply to observers too when they have the separate permission to add followups as observers, or would simply having the permission to add a followup as an observer be enough even if they are an observer via a group?

AldarisPale commented 1 month ago

Thanks for followup, @cconard96 . I would vote for "simply having the permission to add a followup as an observer be enough even if they are an observer via a group?", as it would be inline what the permission says in it's description. I cannot check for it anymore, but if my memory serves me correctly, this is the way it worked in GLPI 9 and the problem appeared in GLPI 10.

For background why it's needed and desired - we have incoming tickets from employees. Tickets are normally invisible to other people, but we need input from other teams, which we then add as groups, as teams might be quite large so adding them one by one as observer is tedious and error prone, especially when people tend to move around in teams.