trasher
commented
2 months ago To reproduce from tests suite:
diff --git a/tests/functional/Glpi/Inventory/Inventory.php b/tests/functional/Glpi/Inventory/Inventory.php
index 95c576353f..5ed5d1f78a 100644
--- a/tests/functional/Glpi/Inventory/Inventory.php
+++ b/tests/functional/Glpi/Inventory/Inventory.php
@@ -4931,7 +4931,7 @@ Compiled Tue 28-Sep-10 13:44 by prod_rel_team",
$services = [$mysql];
$json->content->databases_services = $services;
- $this->doInventory($json);
+ $inventory = $this->doInventory($json);
//check created databases & instances
$this->integer(countElementsInTable(\DatabaseInstance::getTable(), ['is_deleted' => 0]))->isIdenticalTo(1);
@@ -4951,6 +4951,17 @@ Compiled Tue 28-Sep-10 13:44 by prod_rel_team",
$this->array(array_pop($databases))
->string['name']->isIdenticalTo('glpi')
->integer['size']->isIdenticalTo(55000);
+
+ $computer = new \Computer();
+ global $DB;
+ $agents = $DB->request(['FROM' => \Agent::getTable()]);
+ $this->integer(count($agents))->isIdenticalTo(1);
+ $agent = $agents->current();
+ $computers_id = $agent['items_id'];
+ $this->boolean($computer->getFromDB($computers_id))->isTrue();
+ $this->boolean($computer->delete(['id' => $computers_id], true))->isTrue();
}I've not been able to find how to fix. To me, removing data in Computer::pre_deleteItem() should have done the trick, but it did not.
cedric-anne
Code of Conduct
Is there an existing issue for this?
Version
10.0.15
Bug description
I was able to delete a computer from assets without any error but I found later in sql-errors.log a SQL error. I don't think massive action context is relevant.
Relevant log output
Page URL
No response
Steps To reproduce
Your GLPI setup information
Informations sur le système, l'installation et la configuration
Server
Operating system: Linux glpi-10-0-15 6.8.6-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Apr 13 15:14:23 UTC 2024 x86_64 PHP 8.2.18 apache2handler (Core, FFI, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, apcu, bz2, calendar, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imap, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, posix, random, readline, session, shmop, sockets, sodium, standard, sysvmsg, sysvsem, sysvshm, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib) Setup: max_execution_time="300" memory_limit="1280M" post_max_size="1068M" safe_mode="" session.save_handler="files" upload_max_filesize="1024M" disable_functions="" Software: Apache/2.4.59 (Debian) (Apache/2.4.59 (Debian) Server at 192.168.2.15 Port 443 ) Mozilla/5.0 (X11; Linux x86_64; rv:125.0) Gecko/20100101 Firefox/125.0 Server Software: Debian 12 Server Version: 10.11.6-MariaDB-0+deb12u1 Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION Parameters: glpi@127.0.0.1/glpi Host info: 127.0.0.1 via TCP/IP PHP version (8.2.18) is supported. Sessions configuration is OK. Allocated memory is sufficient. mysqli extension is installed. Following extensions are installed: dom, fileinfo, filter, libxml, json, simplexml, xmlreader, xmlwriter. curl extension is installed. gd extension is installed. intl extension is installed. zlib extension is installed. The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present. Database engine version (10.11.6) is supported. No files from previous GLPI version detected. The log file has been created successfully. Write access to /srv/glpi/files/_cache has been validated. Write access to /srv/glpi/files/_cron has been validated. Write access to /srv/glpi/files has been validated. Write access to /srv/glpi/files/_dumps has been validated. Write access to /srv/glpi/files/_graphs has been validated. Write access to /srv/glpi/files/_lock has been validated. Write access to /srv/glpi/files/_pictures has been validated. Write access to /srv/glpi/files/_plugins has been validated. Write access to /srv/glpi/files/_rss has been validated. Write access to /srv/glpi/files/_sessions has been validated. Write access to /srv/glpi/files/_tmp has been validated. Write access to /srv/glpi/files/_uploads has been validated. Web server root directory configuration seems safe. Sessions configuration is secured. OS and PHP are relying on 64 bits integers. exif extension is installed. ldap extension is installed. openssl extension is installed. Following extensions are installed: bz2, Phar, zip. Zend OPcache extension is installed. Following extensions are installed: ctype, iconv, mbstring, sodium. Write access to /srv/glpi/marketplace has been validated. Access to timezone database (mysql) is not allowed.GLPI constants
Libraries
SQL replicas
Notifications
Plugins list
glpiinventory Name: GLPI Inventory Version: 1.3.5 State: Enabled Install Method: ManualAnything else?
No response