cconard96
commented
5 months ago I think I confirmed the issue in the generation of the "web" directory when the marketplace folder is moved outside the GLPI folder.
The relevant code:
public static function getWebDir(string $plugin_key = "", $full = true, $use_url_base = false)
{
/** @var array $CFG_GLPI */
global $CFG_GLPI;
$directory = self::getPhpDir($plugin_key, false);
if ($directory === false) {
return false;
}
$directory = ltrim($directory, '/\\');
if ($full) {
$root = $use_url_base ? $CFG_GLPI['url_base'] : $CFG_GLPI["root_doc"];
$directory = "$root/$directory";
}
return str_replace('\\', '/', $directory);
}I think the best solution is to always serve marketplace plugins through the /marketplace path and proxy the requests to the actual marketplace location. So, calls to Plugin::getWebDir would always return something like http://glpi.bazaar.test/marketplace/glpiinventory while Plugin::getPhpDir returns /var/lib/glpi/marketplace/glpiinventory.
cedric-anne
Code of Conduct
Is there an existing issue for this?
Version
10.0.15 and up to date 10.0.16-dev
Bug description
When using a custom folder location for the marketplace folder, the URL returned by the server looks something like that :
This issue was already reported in the issue 9074 as well as on the forums : https://forum.glpi-project.org/viewtopic.php?id=281140
Relevant log output
No response
Page URL
No response
Steps To reproduce
Your GLPI setup information
Informations sur le système, l'installation et la configuration
Server
Operating system: Linux glpi 6.1.0-21-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.90-1 (2024-05-03) x86_64 PHP 8.2.18 fpm-fcgi (Core, FFI, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, bz2, calendar, cgi-fcgi, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, posix, random, readline, session, shmop, sockets, sodium, standard, sysvmsg, sysvsem, sysvshm, tokenizer, xml, xmlreader, xmlwriter, xsl, zip, zlib) Setup: max_execution_time="30" memory_limit="128M" post_max_size="8M" safe_mode="" session.save_handler="files" upload_max_filesize="2M" disable_functions="" Software: nginx/1.22.1 Mozilla/5.0 (X11; Linux x86_64; rv:126.0) Gecko/20100101 Firefox/126.0 Server Software: Debian 12 Server Version: 10.11.6-MariaDB-0+deb12u1 Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION Parameters: glpi@localhost/glpi Host info: Localhost via UNIX socket PHP version (8.2.18) is supported. Sessions configuration is OK. Allocated memory is sufficient. mysqli extension is installed. Following extensions are installed: dom, fileinfo, filter, libxml, json, simplexml, xmlreader, xmlwriter. curl extension is installed. gd extension is installed. intl extension is installed. zlib extension is installed. The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present. Database engine version (10.11.6) is supported. No files from previous GLPI version detected. The log file has been created successfully. Write access to /var/lib/glpi/files/_cache has been validated. Write access to /var/lib/glpi/files/_cron has been validated. Write access to /var/lib/glpi/files has been validated. Write access to /var/lib/glpi/files/_dumps has been validated. Write access to /var/lib/glpi/files/_graphs has been validated. Write access to /var/lib/glpi/files/_lock has been validated. Write access to /var/lib/glpi/files/_pictures has been validated. Write access to /var/lib/glpi/files/_plugins has been validated. Write access to /var/lib/glpi/files/_rss has been validated. Write access to /var/lib/glpi/files/_sessions has been validated. Write access to /var/lib/glpi/files/_tmp has been validated. Write access to /var/lib/glpi/files/_uploads has been validated. Web server root directory configuration seems safe. Sessions configuration is secured. OS and PHP are relying on 64 bits integers. exif extension is installed. ldap extension is installed. openssl extension is installed. Following extensions are installed: bz2, Phar, zip. Zend OPcache extension is installed. Following extensions are installed: ctype, iconv, mbstring, sodium. Write access to /var/lib/glpi/marketplace has been validated. Access to timezone database (mysql) is not allowed.GLPI constants
Libraries
SQL replicas
Notifications
Plugins list
glpiinventory Name: GLPI Inventory Version: 1.3.5 State: Enabled Install Method: MarketplaceAnything else?
I have not looked into the issue yet, so I don't know if this is a plugin issue, or a GLPI issue or both. I'll try to look into it and propose fix for GLPI and the repo plugins if possible.