zhuravlev-alexey
commented
3 months ago I did find the code that blocks the addition of approval requests in src/CommonITILObject.php, function manageValidationAdd:
...
8392 // Cron or rule process of hability to do
8393 if (
8394 Session::isCron()
8395 || isset($input["_auto_import"])
8396 || isset($input["_rule_process"])
8397 || $validation->can(-1, CREATE, $values)
8398 ) { // cron or allowed user
8399 $add_done = false;
8400 foreach ($validations_to_send as $user) {
8401 // Do not auto add twice same validation
8402 if (!$validation->alreadyExists($values[$self_fk], $user)) {
8403 $values["users_id_validate"] = $user;
8404 if ($validation->add($values)) {
8405 $add_done = true;
8406 }
8407 }
8408 }
...As far as I understand, the idea is that an incorrectly configured business rule or cron jobs can be spammed with requests. This seems to only be true for cron jobs. With business rules, this leads to the inability to send repeated requests for approval when escalating requests or correctly configured rules.
I would suggest making exceptions to business rules:
...
8401 // Do not auto add twice same validation, except for a business rules
8402 if (!$validation->alreadyExists($values[$self_fk], $user) || isset($input["_rule_process"])) {
8403 $values["users_id_validate"] = $user;
8404 if ($validation->add($values)) {
8405 $add_done = true;
8406 }
...
cconard96
Code of Conduct
Is there an existing issue for this?
Version
10.0.15
Bug description
repeated requests for approval through business rules are not sent
Relevant log output
No response
Page URL
No response
Steps To reproduce
Bussiness rules
Create a business rule to send an approval request for any priority change:
Expected result: Whenever a priority change is made, a request for approval is sent to the group manager. Actual result: the approval request is sent only once, all further priority changes do not result in the request being sent. If you delete an approval request, the request will be sent when the next priority changes.
SLA Escalation levels
Create escalation levels for SLA: resolution time, +1 day, +2 days, etc. For each level, set up actions:
Expected result: when the escalation level is reached, a task from the template is added and a request for approval is sent to the group manager. Actual result: the task from the template is added, the approval request is sent only once. If you delete a previous approval request, the request will be sent the next time it is triggered.
Your GLPI setup information
Information about system installation & configuration
GLPI 10.0.15 ( => /var/www/glpi) Installation mode: TARBALL Current language:en_US
Server Operating system: Linux glpi 6.1.0-17-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.69-1 (2023-12-30) x86_64 PHP 8.2.20 apache2handler (Core, FFI, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, apcu, bz2, calendar, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, posix, random, readline, session, shmop, sockets, sodium, standard, sysvmsg, sysvsem, sysvshm, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib) Setup: max_execution_time="30" memory_limit="128M" post_max_size="8M" safe_mode="" session.save_handler="files" upload_max_filesize="2M" disable_functions="" Software: Apache/2.4.59 (Debian) (Apache/2.4.59 (Debian) Server at lk.1it.io Port 443 ) Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0 Server Software: Debian 12 Server Version: 10.11.6-MariaDB-0+deb12u1 Server SQL Mode: STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION Parameters: glpi_db@localhost/glpi Host info: Localhost via UNIX socket
PHP version (8.2.20) is supported.PHP version (8.2.20) is supported. Sessions configuration is OK.Sessions configuration is OK. Allocated memory is sufficient.Allocated memory is sufficient. mysqli extension is installed.mysqli extension is installed. Following extensions are installed: dom, fileinfo, filter, libxml, json, simplexml, xmlreader, xmlwriter.Following extensions are installed: dom, fileinfo, filter, libxml, json, simplexml, xmlreader, xmlwriter. curl extension is installed.curl extension is installed. gd extension is installed.gd extension is installed. intl extension is installed.intl extension is installed. zlib extension is installed.zlib extension is installed. The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present.The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present. Database engine version (10.11.6) is supported.Database engine version (10.11.6) is supported. No files from previous GLPI version detected.No files from previous GLPI version detected. The log file has been created successfully.The log file has been created successfully. Write access to /srv/glpi/files//_cache has been validated. Write access to /srv/glpi/files//_cron has been validated. Write access to /srv/glpi/files/ has been validated. Write access to /srv/glpi/files//_dumps has been validated. Write access to /srv/glpi/files//_graphs has been validated. Write access to /srv/glpi/files//_lock has been validated. Write access to /srv/glpi/files//_pictures has been validated. Write access to /srv/glpi/files//_plugins has been validated. Write access to /srv/glpi/files//_rss has been validated. Write access to /srv/glpi/files//_sessions has been validated. Write access to /srv/glpi/files//_tmp has been validated. Write access to /srv/glpi/files//_uploads has been validated. Write access to /srv/glpi/files//_cache has been validated. Write access to /srv/glpi/files//_cron has been validated. Write access to /srv/glpi/files/ has been validated. Write access to /srv/glpi/files//_dumps has been validated. Write access to /srv/glpi/files//_graphs has been validated. Write access to /srv/glpi/files//_lock has been validated. Write access to /srv/glpi/files//_pictures has been validated. Write access to /srv/glpi/files//_plugins has been validated. Write access to /srv/glpi/files//_rss has been validated. Write access to /srv/glpi/files//_sessions has been validated. Write access to /srv/glpi/files//_tmp has been validated. Write access to /srv/glpi/files//_uploads has been validated.
Web server root directory configuration seems safe.Web server root directory configuration seems safe. Sessions configuration is secured.Sessions configuration is secured. OS and PHP are relying on 64 bits integers.OS and PHP are relying on 64 bits integers. exif extension is installed.exif extension is installed. ldap extension is installed.ldap extension is installed. openssl extension is installed.openssl extension is installed. Following extensions are installed: bz2, Phar, zip.Following extensions are installed: bz2, Phar, zip. Zend OPcache extension is installed.Zend OPcache extension is installed. Following extensions are installed: ctype, iconv, mbstring, sodium.Following extensions are installed: ctype, iconv, mbstring, sodium. Write access to /var/www/glpi/marketplace has been validated.Write access to /var/www/glpi/marketplace has been validated. Timezones seems loaded in database.Timezones seems loaded in database.
GLPI constants
GLPI_ROOT: "/var/www/glpi" GLPI_CONFIG_DIR: "/srv/glpi/config/" GLPI_VAR_DIR: "/srv/glpi/files/" GLPI_LOG_DIR: "/srv/glpi/logs/" GLPI_MARKETPLACE_DIR: "/var/www/glpi/marketplace" GLPI_USE_CSRF_CHECK: "1" GLPI_CSRF_EXPIRES: "7200" GLPI_CSRF_MAX_TOKENS: "100" GLPI_USE_IDOR_CHECK: "1" GLPI_IDOR_EXPIRES: "7200" GLPI_ALLOW_IFRAME_IN_RICH_TEXT: false GLPI_SERVERSIDE_URL_ALLOWLIST: ["/^(https?|feed):\/\/[^@:]+(\/.*)?$/"] GLPI_TELEMETRY_URI: "https://telemetry.glpi-project.org" GLPI_INSTALL_MODE: "TARBALL" GLPI_NETWORK_MAIL: "glpi@teclib.com" GLPI_NETWORK_SERVICES: "https://services.glpi-network.com" GLPI_MARKETPLACE_ALLOW_OVERRIDE: true GLPI_MARKETPLACE_MANUAL_DOWNLOADS: true GLPI_USER_AGENT_EXTRA_COMMENTS: "" GLPI_DISABLE_ONLY_FULL_GROUP_BY_SQL_MODE: "1" GLPI_AJAX_DASHBOARD: "1" GLPI_CALDAV_IMPORT_STATE: 0 GLPI_DEMO_MODE: "0" GLPI_CENTRAL_WARNINGS: "1" GLPI_TEXT_MAXSIZE: "4000" GLPI_DOC_DIR: "/srv/glpi/files/" GLPI_CACHE_DIR: "/srv/glpi/files//_cache" GLPI_CRON_DIR: "/srv/glpi/files//_cron" GLPI_DUMP_DIR: "/srv/glpi/files//_dumps" GLPI_GRAPH_DIR: "/srv/glpi/files//_graphs" GLPI_LOCAL_I18N_DIR: "/srv/glpi/files//_locales" GLPI_LOCK_DIR: "/srv/glpi/files//_lock" GLPI_PICTURE_DIR: "/srv/glpi/files//_pictures" GLPI_PLUGIN_DOC_DIR: "/srv/glpi/files//_plugins" GLPI_RSS_DIR: "/srv/glpi/files//_rss" GLPI_SESSION_DIR: "/srv/glpi/files//_sessions" GLPI_TMP_DIR: "/srv/glpi/files//_tmp" GLPI_UPLOAD_DIR: "/srv/glpi/files//_uploads" GLPI_INVENTORY_DIR: "/srv/glpi/files//_inventories" GLPI_NETWORK_REGISTRATION_API_URL: "https://services.glpi-network.com/api/registration/" GLPI_MARKETPLACE_PLUGINS_API_URI: "https://services.glpi-network.com/api/marketplace/" GLPI_I18N_DIR: "/var/www/glpi/locales" GLPI_VERSION: "10.0.15" GLPI_SCHEMA_VERSION: "10.0.15@2eed74704cb07e0bac48b933cbd5c1c356f09629" GLPI_MARKETPLACE_PRERELEASES: false GLPI_MIN_PHP: "7.4.0" GLPI_MAX_PHP: "8.4.0" GLPI_YEAR: "2024"
Libraries
htmlawed/htmlawed version 1.2.14 in (/var/www/glpi/vendor/htmlawed/htmlawed) phpmailer/phpmailer version 6.8.0 in (/var/www/glpi/vendor/phpmailer/phpmailer/src) simplepie/simplepie version 1.5.8 in (/var/www/glpi/vendor/simplepie/simplepie/library) tecnickcom/tcpdf version 6.7.5 in (/var/www/glpi/vendor/tecnickcom/tcpdf) michelf/php-markdown in (/var/www/glpi/vendor/michelf/php-markdown/Michelf) true/punycode in (/var/www/glpi/vendor/true/punycode/src) iamcal/lib_autolink in (/var/www/glpi/vendor/iamcal/lib_autolink) sabre/dav in (/var/www/glpi/vendor/sabre/dav/lib/DAV) sabre/http in (/var/www/glpi/vendor/sabre/http/lib) sabre/uri in (/var/www/glpi/vendor/sabre/uri/lib) sabre/vobject in (/var/www/glpi/vendor/sabre/vobject/lib) laminas/laminas-i18n in (/var/www/glpi/vendor/laminas/laminas-i18n/src) laminas/laminas-servicemanager in (/var/www/glpi/vendor/laminas/laminas-servicemanager/src) monolog/monolog in (/var/www/glpi/vendor/monolog/monolog/src/Monolog) sebastian/diff in (/var/www/glpi/vendor/sebastian/diff/src) donatj/phpuseragentparser in (/var/www/glpi/vendor/donatj/phpuseragentparser/src/UserAgent) elvanto/litemoji in (/var/www/glpi/vendor/elvanto/litemoji/src) symfony/console in (/var/www/glpi/vendor/symfony/console) scssphp/scssphp in (/var/www/glpi/vendor/scssphp/scssphp/src) laminas/laminas-mail in (/var/www/glpi/vendor/laminas/laminas-mail/src/Protocol) laminas/laminas-mime in (/var/www/glpi/vendor/laminas/laminas-mime/src) rlanvin/php-rrule in (/var/www/glpi/vendor/rlanvin/php-rrule/src) ramsey/uuid in (/var/www/glpi/vendor/ramsey/uuid/src) psr/log in (/var/www/glpi/vendor/psr/log/Psr/Log) psr/simple-cache in (/var/www/glpi/vendor/psr/simple-cache/src) psr/cache in (/var/www/glpi/vendor/psr/cache/src) league/csv in (/var/www/glpi/vendor/league/csv/src) mexitek/phpcolors in (/var/www/glpi/vendor/mexitek/phpcolors/src/Mexitek/PHPColors) guzzlehttp/guzzle in (/var/www/glpi/vendor/guzzlehttp/guzzle/src) guzzlehttp/psr7 in (/var/www/glpi/vendor/guzzlehttp/psr7/src) glpi-project/inventory_format in (/var/www/glpi/vendor/glpi-project/inventory_format/lib/php) wapmorgan/unified-archive in (/var/www/glpi/vendor/wapmorgan/unified-archive/src) paragonie/sodium_compat in (/var/www/glpi/vendor/paragonie/sodium_compat/src) symfony/cache in (/var/www/glpi/vendor/symfony/cache) html2text/html2text in (/var/www/glpi/vendor/html2text/html2text/src) symfony/css-selector in (/var/www/glpi/vendor/symfony/css-selector) symfony/dom-crawler in (/var/www/glpi/vendor/symfony/dom-crawler) twig/twig in (/var/www/glpi/vendor/twig/twig/src) twig/string-extra in (/var/www/glpi/vendor/twig/string-extra) symfony/polyfill-ctype not found symfony/polyfill-iconv not found symfony/polyfill-mbstring not found symfony/polyfill-php80 not found symfony/polyfill-php81 not found symfony/polyfill-php82 in (/var/www/glpi/vendor/symfony/polyfill-php82) league/oauth2-client in (/var/www/glpi/vendor/league/oauth2-client/src/Provider) league/oauth2-google in (/var/www/glpi/vendor/league/oauth2-google/src/Provider) thenetworg/oauth2-azure in (/var/www/glpi/vendor/thenetworg/oauth2-azure/src/Provider) phpCas version 1.6.0 in (/usr/share/php/CAS/source)
Plugins list
Anything else?
No response