search

glpi-project / glpi

GLPI is a Free Asset and IT Management Software package, Data center management, ITIL Service Desk, licenses tracking and software auditing.
https://glpi-project.org
GNU General Public License v3.0
4.3k stars 1.29k forks source link

[GLPI 11.0.0] - Compatibility with HTML5 #18217

Open RobertoMarcelino opened 1 week ago

RobertoMarcelino commented 1 week ago

Code of Conduct

Contribution description

We suggest modifying the file glpi/src/NotificationTemplate.php to ensure compatibility with HTML5, in the following lines:

- 276 "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Transitional//EN\"
- 277 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'>" .
- 278 "<html>
- 279 <head>
- 280 <META http-equiv='Content-Type' content='text/html; charset=utf-8'>

+ 276 "<!DOCTYPE html>" .
+ 277 "<html>
+ 278 <head>
+ 279 <meta charset='UTF-8'><meta name='viewport' content='width=device-width, initial-scale=1.0'><meta name='color-scheme' content='light dark'>
GSGustavo commented 1 week ago

Hi Robeto, how are you? One question, the original code, is represented in witch HTML version?

RobertoMarcelino commented 1 week ago

The NotificationTemplate.php file has remained largely unchanged in almost all versions of GLPI.

This code was tested in version 10.0.16 and in version 11.0.0-alpha.

The proposal aims to make ticket responses compatible with HTML5 and apply dark mode settings.

trasher commented 1 week ago

Please open a PR with your changes proposal