Fix(Inventory): take car of 'default_software_helpdesk_visible' from software inventory - Githubissues

glpi-project / glpi

GLPI is a Free Asset and IT Management Software package, Data center management, ITIL Service Desk, licenses tracking and software auditing.

https://glpi-project.org

GNU General Public License v3.0

4.34k stars 1.3k forks source link

Fix(Inventory): take car of 'default_software_helpdesk_visible' from software inventory #18369

Open stonebuzz opened 4 days ago

stonebuzz commented 4 days ago

Checklist before requesting a review

Please delete options that are not relevant.

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my code.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] This change requires a documentation update.

Description

It fixes !35300

Currently, the software inventory does not take into account the is_helpdesk_visible option in GLPI's general configuration.

This option is now managed both during the creation of the software and when it is updated.

I took the opportunity in this PR to simplify the code with a dedicated function (We may have other cases to handle in the future)

Screenshots (if appropriate):