ppenin commented 6 years ago

Steps to reproduce : Send a mail with images/screenshots embedded in the body Collect this mail with mailgate add followup with text and copy-paste an image
Expected result : Images displayed correctly in GLPI (ticket page and followups page) Images displayed correctly in the mail sent by GLPI no mailgate and queuednotification tasks stucked in running
Actual result : Images displayed correctly in GLPI (ticket page and followups page) - test ok Images not displayed correctly in the mail sent by GLPI - test not ok no mailgate and queuednotification tasks stucked in running - test ok
Screenshot of the problem

Server address is correct but no image is displayed in the mail

Your GLPI setup (you can find it in Setup > General menu, System tab) :

GLPI 9.2.3 (/glpi => /usr/share/glpi) Installation mode: TARBALL

Server

Operating system: Linux s001linux02 4.4.0-119-generic #143-Ubuntu SMP Mon Apr 2 16:08:24 UTC 2018 x86_64 PHP 7.0.29-1+ubuntu16.04.1+deb.sury.org+1 apache2handler (Core, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, calendar, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imap, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, posix, readline, session, shmop, sockets, standard, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xml, xmlreader, xmlwriter, xsl, zlib) Setup: max_execution_time="30" memory_limit="256M" post_max_size="100M" safe_mode="" session.save_handler="files" upload_max_filesize="100M" Software: Apache/2.4.18 (Ubuntu) (Apache/2.4.18 (Ubuntu) Server at 10.100.10.18 Port 80) Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Server Software: (Ubuntu) Server Version: 5.7.22-0ubuntu0.16.04.1 Server SQL Mode: Parameters: root@localhost/glpi Host info: Localhost via UNIX socket

mysqli extension is installed ctype extension is installed fileinfo extension is installed json extension is installed mbstring extension is installed zlib extension is installed curl extension is installed gd extension is installed simplexml extension is installed xml extension is installed ldap extension is installed imap extension is installed Zend OPcache extension is installed APCu extension is not present xmlrpc extension is not present OK/usr/share/glpi/config : OK OK/usr/share/glpi/files : OK OK/usr/share/glpi/files/_dumps : OK OK/usr/share/glpi/files/_sessions : OK OK/usr/share/glpi/files/_cron : OK OK/usr/share/glpi/files/_graphs : OK OK/usr/share/glpi/files/_lock : OK OK/usr/share/glpi/files/_plugins : OK OK/usr/share/glpi/files/_tmp : OK OK/usr/share/glpi/files/_cache : OK OK/usr/share/glpi/files/_rss : OK OK/usr/share/glpi/files/_uploads : OK OK/usr/share/glpi/files/_pictures : OK OK/usr/share/glpi/files/_log : OK Web access to files directory is protectedWeb access to files directory is protected : OK

Libraries

htmLawed version 1.2.4 in (/usr/share/glpi/lib/htmlawed) phpCas version 1.3.5 in (/usr/share/glpi/vendor/jasig/phpcas/source) PHPMailer version 5.2.26 in (/usr/share/glpi/vendor/phpmailer/phpmailer) SimplePie version 1.5.1 in (/usr/share/glpi/vendor/simplepie/simplepie/library) TCPDF version 6.2.16 in (/usr/share/glpi/vendor/tecnickcom/tcpdf) michelf/php-markdown in (/usr/share/glpi/vendor/michelf/php-markdown/Michelf) true/punycode in (/usr/share/glpi/vendor/true/punycode/src) iacaml/autolink in (/usr/share/glpi/vendor/iamcal/lib_autolink) sabre/vobject in (/usr/share/glpi/vendor/sabre/vobject/lib)

LDAP directories

Server: '10.100.10.1', Port: '389', BaseDN: 'DC=mydomain,DC=priv', Connection filter: none, RootDN: 'CN=Service Alerte,OU=Comptes de Services,OU=001 (FSS),DC=mydomain,DC=priv', Use TLS: none

SQL replicas

Not active

Notifications

Way of sending emails: SMTP (hotline-glpi@10.100.10.66)

Mails receivers

Name: 'xx@mydomain.fr' Active: Yes Server: '{10.100.10.66/pop/novalidate-cert/notls}INBOX' Login: 'hotline-GLPI' Password: Yes

Plugins list

fields               Name: Champs supplémentaires         Version: 1.7.0      State: Enabled
escalade             Name: Escalades                      Version: 2.2.1      State: Enabled
simcard              Name: Gestion de cartes SIM          Version: 1.4.2      State: Enabled
pdf                  Name: Impression pdf                 Version: 1.3.1.1    State: Enabled
datainjection        Name: Injection de fichiers          Version: 2.5.0      State: Enabled
mailanalyzer         Name: Mail Analyzer                  Version: 1.3.8      State: Enabled
ocsinventoryng       Name: OCS Inventory NG               Version: 1.4.3      State: Enabled
mreporting           Name: Plus de rapports               Version: 1.4.0      State: Enabled
reports              Name: Rapports                       Version: 1.11.1     State: Enabled
dashboard            Name: Tableau de bord                Version: 0.9.2      State: Enabled

OCS Inventory NG Host: localhost Connection: Ok Use the OCSNG software dictionary: No

trasher commented 6 years ago

I'm pretty sure another issue is (was) already opened for that.

ppenin commented 6 years ago

Yes it was me but in 9.2.1 and 9.2.2

3494 and #3284

ppenin commented 6 years ago

you can contact me in PM if you want to watch directly

ameurou commented 6 years ago

You should apply the whole fixes made by @trasher in #3653 :

https://github.com/glpi-project/glpi/blob/97253d5a1a53e0f77b11e37cbb78d664b4ae55e7/inc/html.class.php#L5529-L5549

ppenin commented 6 years ago

this fix is already in 9.2.3 I fixed the issue with https://github.com/glpi-project/glpi/pull/3694/commits/8bd958ae02feae207cda8fd92d29d8e6b2de4d58 and the images ares correctly displayed in mails but it stucks queuednotification task.

ppenin commented 6 years ago

With the fix 8bd958a

Mailgate and queuednotifcation are stucked when a mail is collected
the mail contains only one picture et not the others

In GLPI

ameurou commented 6 years ago

you need this one 666025b718b514c511efc93f83e3feecb12b641d too there is a small error in 8bd958a

ppenin commented 6 years ago

The fix 666025b doesn't work for me in 9.2.3 It stucks mailgate and queuednotification when a mail is collected. First images are not displayed in the mail even if the URL is correct.

Display is ok in GLPI

ppenin commented 6 years ago

With this fix, images are correctly displayed in mail and in glpi now. Yes ! But automatic tasks are stucked immediately when the mail is collected. Back to square one !