glpi-project / glpi

GLPI is a Free Asset and IT Management Software package, Data center management, ITIL Service Desk, licenses tracking and software auditing.
https://glpi-project.org
GNU General Public License v3.0
4.24k stars 1.29k forks source link

`phpCAS` 1.3.9+ recommends installation via composer #9428

Closed AKorezin closed 2 years ago

AKorezin commented 3 years ago

Describe the bug

phpCAS since version 1.3.9 recommends composer installation.

phpCAS autoloader is deprecated. Install phpCAS using composer instead. in /usr/local/lib/php/CAS/Autoload.php at line 86

Previously I install it with pear from release tarball. Now I have to

  1. Download composer.json from github tag.
  2. Modify it by adding jasig/phpcas to require.
  3. Exec composer update with autoloader optimizations.

Page(s) URL

Not available.

To reproduce

Steps to reproduce the behavior:

  1. Download https://github.com/apereo/phpCAS/releases/download/1.4.0/CAS-1.4.0.tgz
  2. Install it with pear install CAS-1.4.0.tgz
  3. Try to do glpi installation.
  4. See deprecation warning.

Expected behavior

I think that since phpCAS provides composer interface it can be included in official release.

Logs

Not available.

Screenshots

Not available.

Your GLPI setup (you can find it in Setup > General menu, System tab)

General ``` GLPI 9.5.5 ( => /var/www/html) Installation mode: TARBALL ```
Server ``` Operating system: Linux 273372e834c6 5.13.12-arch1-1 #1 SMP PREEMPT Wed, 18 Aug 2021 20:49:03 +0000 x86_64 PHP 7.4.22 apache2handler (Core, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, apcu, bz2, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, hash, iconv, igbinary, imap, intl, json, ldap, libxml, mbstring, memcached, mysqli, mysqlnd, openssl, pcntl, pcre, pdo_sqlite, posix, session, sodium, sqlite3, standard, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, zip, zlib) Setup: max_execution_time="600" memory_limit="64M" post_max_size="8M" safe_mode="" session.save_handler="memcached" upload_max_filesize="2M" Software: Apache () Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36 Server Software: mariadb.org binary distribution Server Version: 10.6.4-MariaDB-1:10.6.4+maria~focal Server SQL Mode: Parameters: glpi@mariadb/glpi Host info: mariadb via TCP/IP PHP version is at least 7.2.0 - Perfect! Sessions support is available - Perfect! Allocated memory > 64 Mio - Perfect! mysqli extension is installed ctype extension is installed fileinfo extension is installed json extension is installed mbstring extension is installed iconv extension is installed zlib extension is installed curl extension is installed gd extension is installed simplexml extension is installed intl extension is installed ldap extension is installed apcu extension is installed Zend OPcache extension is installed xmlrpc extension is installed CAS extension is installed exif extension is installed zip extension is installed bz2 extension is installed sodium extension is installed Database version seems correct (10.6.4) - Perfect! Timezones seems loaded in database Write access to /var/www/html/files/_cache has been validated. Write access to /var/www/html/config has been validated. Write access to /var/www/html/files/_cron has been validated. Write access to /var/www/html/files has been validated. Write access to /var/www/html/files/_dumps has been validated. Write access to /var/www/html/files/_graphs has been validated. Write access to /var/www/html/files/_lock has been validated. Write access to /var/www/html/files/_pictures has been validated. Write access to /var/www/html/files/_plugins has been validated. Write access to /var/www/html/files/_rss has been validated. Write access to /var/www/html/files/_sessions has been validated. Write access to /var/www/html/files/_tmp has been validated. Write access to /var/www/html/files/_uploads has been validated. Write access to /var/www/html/marketplace has been validated. Web access to files directory is protectedWeb access to files directory is protected ```
GLPI constants ``` GLPI_ROOT: /var/www/html GLPI_CONFIG_DIR: /var/www/html/config GLPI_VAR_DIR: /var/www/html/files GLPI_MARKETPLACE_DIR: /var/www/html/marketplace GLPI_USE_CSRF_CHECK: 1 GLPI_CSRF_EXPIRES: 7200 GLPI_CSRF_MAX_TOKENS: 100 GLPI_USE_IDOR_CHECK: 1 GLPI_IDOR_EXPIRES: 7200 GLPI_ALLOW_IFRAME_IN_RICH_TEXT: GLPI_TELEMETRY_URI: https://telemetry.glpi-project.org GLPI_INSTALL_MODE: TARBALL GLPI_NETWORK_MAIL: glpi@teclib.com GLPI_NETWORK_SERVICES: https://services.glpi-network.com GLPI_MARKETPLACE_PRERELEASES: GLPI_MARKETPLACE_ALLOW_OVERRIDE: 1 GLPI_MARKETPLACE_MANUAL_DOWNLOADS: 1 GLPI_USER_AGENT_EXTRA_COMMENTS: GLPI_AJAX_DASHBOARD: 1 GLPI_CALDAV_IMPORT_STATE: 0 GLPI_DEMO_MODE: 0 GLPI_FORCE_EMPTY_SQL_MODE: 1 GLPI_DOC_DIR: /var/www/html/files GLPI_CACHE_DIR: /var/www/html/files/_cache GLPI_CRON_DIR: /var/www/html/files/_cron GLPI_DUMP_DIR: /var/www/html/files/_dumps GLPI_GRAPH_DIR: /var/www/html/files/_graphs GLPI_LOCAL_I18N_DIR: /var/www/html/files/_locales GLPI_LOCK_DIR: /var/www/html/files/_lock GLPI_LOG_DIR: /var/www/html/files/_log GLPI_PICTURE_DIR: /var/www/html/files/_pictures GLPI_PLUGIN_DOC_DIR: /var/www/html/files/_plugins GLPI_RSS_DIR: /var/www/html/files/_rss GLPI_SESSION_DIR: /var/www/html/files/_sessions GLPI_TMP_DIR: /var/www/html/files/_tmp GLPI_UPLOAD_DIR: /var/www/html/files/_uploads GLPI_NETWORK_REGISTRATION_API_URL: https://services.glpi-network.com/api/registration/ GLPI_MARKETPLACE_PLUGINS_API_URI: https://services.glpi-network.com/api/glpi-plugins/ GLPI_I18N_DIR: /var/www/html/locales GLPI_VERSION: 9.5.5 GLPI_SCHEMA_VERSION: 9.5.5 GLPI_MIN_PHP: 7.2.0 GLPI_YEAR: 2021 ```
Libraries ``` htmlawed/htmlawed version 1.2.5 in (/var/www/html/vendor/htmlawed/htmlawed) phpmailer/phpmailer version 6.1.6 in (/var/www/html/vendor/phpmailer/phpmailer/src) simplepie/simplepie version 1.5.6 in (/var/www/html/vendor/simplepie/simplepie/library) tecnickcom/tcpdf version 6.3.5 in (/var/www/html/vendor/tecnickcom/tcpdf) michelf/php-markdown in (/var/www/html/vendor/michelf/php-markdown/Michelf) true/punycode in (/var/www/html/vendor/true/punycode/src) iamcal/lib_autolink in (/var/www/html/vendor/iamcal/lib_autolink) sabre/dav in (/var/www/html/vendor/sabre/dav/lib/DAV) sabre/http in (/var/www/html/vendor/sabre/http/lib) sabre/uri in (/var/www/html/vendor/sabre/uri/lib) sabre/vobject in (/var/www/html/vendor/sabre/vobject/lib) laminas/laminas-cache in (/var/www/html/vendor/laminas/laminas-cache/src) laminas/laminas-i18n in (/var/www/html/vendor/laminas/laminas-i18n/src) laminas/laminas-serializer in (/var/www/html/vendor/laminas/laminas-serializer/src) monolog/monolog in (/var/www/html/vendor/monolog/monolog/src/Monolog) sebastian/diff in (/var/www/html/vendor/sebastian/diff/src) elvanto/litemoji in (/var/www/html/vendor/elvanto/litemoji/src) symfony/console in (/var/www/html/vendor/symfony/console) scssphp/scssphp in (/var/www/html/vendor/scssphp/scssphp/src) laminas/laminas-mail in (/var/www/html/vendor/laminas/laminas-mail/src/Protocol) laminas/laminas-mime in (/var/www/html/vendor/laminas/laminas-mime/src) rlanvin/php-rrule in (/var/www/html/vendor/rlanvin/php-rrule/src) blueimp/jquery-file-upload in (/var/www/html/vendor/blueimp/jquery-file-upload/server/php) ramsey/uuid in (/var/www/html/vendor/ramsey/uuid/src) psr/log in (/var/www/html/vendor/psr/log/Psr/Log) psr/simple-cache in (/var/www/html/vendor/psr/simple-cache/src) mexitek/phpcolors in (/var/www/html/vendor/mexitek/phpcolors/src/Mexitek/PHPColors) guzzlehttp/guzzle in (/var/www/html/vendor/guzzlehttp/guzzle/src) guzzlehttp/psr7 in (/var/www/html/vendor/guzzlehttp/psr7/src) wapmorgan/unified-archive in (/var/www/html/vendor/wapmorgan/unified-archive/src) paragonie/sodium_compat in (/var/www/html/vendor/paragonie/sodium_compat/src) phpCas version 1.4.0 in (/usr/local/lib/php) ```
SQL replicas ``` Not active ```
Notifications ``` Way of sending emails: PHP ```

 

Additional context

https://github.com/apereo/phpCAS/blob/e19040a2b50c8883b0da7c204e5f5e907d5fb407/source/CAS/Autoload.php#L86

cedric-anne commented 3 years ago

Hi,

Due to licence conflicts, we cannot embed phpCAS in GLPI official release, but this dependency could be embedded into a dedicated GLPI plugin that could be easilly installed using the marketplace.

Regards

AKorezin commented 3 years ago

Hello @cedric-anne. So GLPI functions related to phpCAS has to be moved to separate plugin?

github-actions[bot] commented 2 years ago

There has been no activity on this issue for some time and therefore it is considered stale and will be closed automatically in 10 days.

If this issue is related to a bug, please try to reproduce on latest release. If the problem persist, feel free to add a comment to revive this issue. If it is related to a new feature, please open a topic to discuss with community about this enhancement on suggestion website.

You may also consider taking a subscription to get professionnal support or contact GLPI editor team directly.

AKorezin commented 2 years ago

bump

github-actions[bot] commented 2 years ago

There has been no activity on this issue for some time and therefore it is considered stale and will be closed automatically in 10 days.

If this issue is related to a bug, please try to reproduce on latest release. If the problem persist, feel free to add a comment to revive this issue. If it is related to a new feature, please open a topic to discuss with community about this enhancement on suggestion website.

You may also consider taking a subscription to get professionnal support or contact GLPI editor team directly.

medilies commented 2 years ago

bump

cedric-anne commented 2 years ago

So GLPI functions related to phpCAS has to be moved to separate plugin?

A quick solution would be to just embed this library in a plugin, without changing the GLPI core behaviour.

trasher commented 2 years ago

PHPCas cannot be shipped with GLPI releases because of licensing issues so, you now have to install it on your own.

You can create a plugin as proposed, this sounds a solution that should be used by all glpi users. This does not mean that GLPI features that relies on phpcas will be moved to a plugin; it will stay in core.