search

glpi-project / php-library-glpi

GLPI API Client Library for PHP
https://glpi-project.github.io/php-library-glpi/
GNU General Public License v3.0
25 stars 21 forks source link

Fix Session-Token key accessed without checks #67

Closed C-Duv closed 6 years ago

C-Duv commented 6 years ago

Changes description

It resolves the issue that caused Undefined index: Session-Token PHP notices.

Checklist

Please check if your PR fulfills the following specifications:

References

Closes #64

ghost commented 6 years ago

There were the following issues with this Pull Request

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

DIOHz0r commented 6 years ago

I recomend you to let this code as it is and solve first the issue with the init session action 'cause the Session-Token is always mandatory for call all GLPI Endpoints (excluding only for lostPassword and initSession).

ajsb85 commented 6 years ago

Hi, @C-Duv Remove the prefix WIP when the PR is ready to review. At the moment the Travis CI build failed. Thank you very much.

DIOHz0r commented 6 years ago

@btry I'm leaving the old code as it was and only fix a problem with the change made by @C-Duv. The change for your comments will be on another PR.

btry commented 6 years ago

Thank you @DIOHz0r . Don't forget to use a more accurate name for exceptions.

btry commented 6 years ago

@DIOHz0r

can you run git rebase HEAD^^ -i to edit the message of the 1st commit and add a Signed-Off-By tag for @C-Duv ?