Open AymLaf opened 6 years ago
Hello, thanks for the PR. Globally, this seems pretty good; I did not review nor tested yet.
Anyways, please rebase your branch on develop, new features should not reach master (only bugfixes until a new version is released). Once rebased,
I'm not very fan of the password verification as displayed (I know this is something quite complicated).
Finally, you have many CS issues that must be fixed ;)
I changed the way to display the password's verifications :
Just installed your branch, and I have 2 issues:
[28-May-2018 13:47:46 UTC] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Builder.php on line 1185
[28-May-2018 13:47:46 UTC] PHP Stack trace:
[28-May-2018 13:47:46 UTC] PHP 1. {main}() /var/www/webapps/telemetry/public/index.php:0
[28-May-2018 13:47:46 UTC] PHP 2. Slim\App->run() /var/www/webapps/telemetry/public/index.php:201
[28-May-2018 13:47:46 UTC] PHP 3. Slim\App->process() /var/www/webapps/telemetry/vendor/slim/slim/Slim/App.php:295
[28-May-2018 13:47:46 UTC] PHP 4. Slim\App->callMiddlewareStack() /var/www/webapps/telemetry/vendor/slim/slim/Slim/App.php:370
[28-May-2018 13:47:46 UTC] PHP 5. Slim\App->Slim\{closure}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:122
[28-May-2018 13:47:46 UTC] PHP 6. call_user_func:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 7. Slim\DeferredCallable->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 8. call_user_func_array:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 9. Slim\Container->{closure:/var/www/webapps/telemetry/app/init.php:248-264}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 10. Slim\App->Slim\{closure}() /var/www/webapps/telemetry/app/init.php:263
[28-May-2018 13:47:46 UTC] PHP 11. call_user_func:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 12. Slim\DeferredCallable->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 13. call_user_func_array:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 14. RKA\Middleware\SchemeAndHost->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 15. Slim\App->__invoke() /var/www/webapps/telemetry/vendor/akrabat/rka-scheme-and-host-detection-middleware/src/SchemeAndHost.php:66
[28-May-2018 13:47:46 UTC] PHP 16. Slim\Route->run() /var/www/webapps/telemetry/vendor/slim/slim/Slim/App.php:476
[28-May-2018 13:47:46 UTC] PHP 17. Slim\Route->callMiddlewareStack() /var/www/webapps/telemetry/vendor/slim/slim/Slim/Route.php:316
[28-May-2018 13:47:46 UTC] PHP 18. Slim\Route->Slim\{closure}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:122
[28-May-2018 13:47:46 UTC] PHP 19. call_user_func:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 20. Slim\DeferredCallable->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 21. call_user_func_array:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 22. Slim\Csrf\Guard->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 23. Slim\Route->Slim\{closure}() /var/www/webapps/telemetry/vendor/slim/csrf/src/Guard.php:167
[28-May-2018 13:47:46 UTC] PHP 24. call_user_func:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 25. Slim\DeferredCallable->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 26. call_user_func_array:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 27. GLPI\Telemetry\Middleware\CsrfView->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 28. Slim\Route->__invoke() /var/www/webapps/telemetry/app/Middleware/CsrfView.php:23
[28-May-2018 13:47:46 UTC] PHP 29. Slim\Handlers\Strategies\RequestResponse->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/Route.php:344
[28-May-2018 13:47:46 UTC] PHP 30. call_user_func:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php:41}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php:41
[28-May-2018 13:47:46 UTC] PHP 31. GLPI\Telemetry\Controllers\Reference->view() /var/www/webapps/telemetry/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php:41
[28-May-2018 13:47:46 UTC] PHP 32. Illuminate\Database\Eloquent\Model::active() /var/www/webapps/telemetry/app/Controllers/Reference.php:27
[28-May-2018 13:47:46 UTC] PHP 33. Illuminate\Database\Eloquent\Model::__callStatic() /var/www/webapps/telemetry/app/Controllers/Reference.php:27
[28-May-2018 13:47:46 UTC] PHP 34. call_user_func_array:{/var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Model.php:3540}() /var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Model.php:3540
[28-May-2018 13:47:46 UTC] PHP 35. GLPI\Telemetry\Models\Reference->active() /var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Model.php:3540
[28-May-2018 13:47:46 UTC] PHP 36. GLPI\Telemetry\Models\Reference->__call() /var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Model.php:3540
[28-May-2018 13:47:46 UTC] PHP 37. call_user_func_array:{/var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Model.php:3526}() /var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Model.php:3526
[28-May-2018 13:47:46 UTC] PHP 38. Illuminate\Database\Eloquent\Builder->active() /var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Model.php:3526
[28-May-2018 13:47:46 UTC] PHP 39. Illuminate\Database\Eloquent\Builder->__call() /var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Model.php:3526
[28-May-2018 13:47:46 UTC] PHP 40. Illuminate\Database\Eloquent\Builder->callScope() /var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Builder.php:1419
[28-May-2018 13:47:46 UTC] PHP 41. count() /var/www/webapps/telemetry/vendor/illuminate/database/Eloquent/Builder.php:1185
[28-May-2018 13:47:46 UTC] PHP Notice: Undefined index: user in /var/www/webapps/telemetry/app/Controllers/Reference.php on line 36
[28-May-2018 13:47:46 UTC] PHP Stack trace:
[28-May-2018 13:47:46 UTC] PHP 1. {main}() /var/www/webapps/telemetry/public/index.php:0
[28-May-2018 13:47:46 UTC] PHP 2. Slim\App->run() /var/www/webapps/telemetry/public/index.php:201
[28-May-2018 13:47:46 UTC] PHP 3. Slim\App->process() /var/www/webapps/telemetry/vendor/slim/slim/Slim/App.php:295
[28-May-2018 13:47:46 UTC] PHP 4. Slim\App->callMiddlewareStack() /var/www/webapps/telemetry/vendor/slim/slim/Slim/App.php:370
[28-May-2018 13:47:46 UTC] PHP 5. Slim\App->Slim\{closure}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:122
[28-May-2018 13:47:46 UTC] PHP 6. call_user_func:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 7. Slim\DeferredCallable->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 8. call_user_func_array:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 9. Slim\Container->{closure:/var/www/webapps/telemetry/app/init.php:248-264}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 10. Slim\App->Slim\{closure}() /var/www/webapps/telemetry/app/init.php:263
[28-May-2018 13:47:46 UTC] PHP 11. call_user_func:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 12. Slim\DeferredCallable->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 13. call_user_func_array:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 14. RKA\Middleware\SchemeAndHost->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 15. Slim\App->__invoke() /var/www/webapps/telemetry/vendor/akrabat/rka-scheme-and-host-detection-middleware/src/SchemeAndHost.php:66
[28-May-2018 13:47:46 UTC] PHP 16. Slim\Route->run() /var/www/webapps/telemetry/vendor/slim/slim/Slim/App.php:476
[28-May-2018 13:47:46 UTC] PHP 17. Slim\Route->callMiddlewareStack() /var/www/webapps/telemetry/vendor/slim/slim/Slim/Route.php:316
[28-May-2018 13:47:46 UTC] PHP 18. Slim\Route->Slim\{closure}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:122
[28-May-2018 13:47:46 UTC] PHP 19. call_user_func:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 20. Slim\DeferredCallable->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 21. call_user_func_array:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 22. Slim\Csrf\Guard->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 23. Slim\Route->Slim\{closure}() /var/www/webapps/telemetry/vendor/slim/csrf/src/Guard.php:167
[28-May-2018 13:47:46 UTC] PHP 24. call_user_func:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 25. Slim\DeferredCallable->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/MiddlewareAwareTrait.php:73
[28-May-2018 13:47:46 UTC] PHP 26. call_user_func_array:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 27. GLPI\Telemetry\Middleware\CsrfView->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/DeferredCallable.php:43
[28-May-2018 13:47:46 UTC] PHP 28. Slim\Route->__invoke() /var/www/webapps/telemetry/app/Middleware/CsrfView.php:23
[28-May-2018 13:47:46 UTC] PHP 29. Slim\Handlers\Strategies\RequestResponse->__invoke() /var/www/webapps/telemetry/vendor/slim/slim/Slim/Route.php:344
[28-May-2018 13:47:46 UTC] PHP 30. call_user_func:{/var/www/webapps/telemetry/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php:41}() /var/www/webapps/telemetry/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php:41
[28-May-2018 13:47:46 UTC] PHP 31. GLPI\Telemetry\Controllers\Reference->view() /var/www/webapps/telemetry/vendor/slim/slim/Slim/Handlers/Strategies/RequestResponse.php:41
New features :
Pages ajoutées :
Possibilités :
Une fois connecté je peux :
En tant qu’administrateur je peux :
Comportement des références : Trois états sont possibles :
A la création d’une référence, celle-ci aura par défaut l’état « Pending ». Seulement un administrateur peut changer cet état. Au changement d’état un email sera envoyé automatiquement à une des adresses emails spécifiées. Soit celle de l’utilisateur rattaché à la référence, soit celle de la référence ou encore une adresse rentrée manuellement par l’administrateur. Peut importe l’état dans lequel se trouve votre référence vous avez la possibilité de l’éditer. En revanche une édition fera passer votre référence de son état actuel à « Pending ». Peut importe l’état dans lequel se trouve votre référence vous avez la possibilité de la supprimer. Seule les références avec un état « Accepted » seront prises en compte dans la page de visualisation de toutes les références : page « References ».