search

glromeo / esbuild-sass-plugin

esbuild plugin for sass
MIT License
155 stars 40 forks source link

Merging Nathan's async changes #163

Closed glromeo closed 9 months ago

NathanBeddoeWebDev commented 9 months ago

Thanks. I've removed the naming changes, and confirmed with benchmark that the performance boost is still there. I'll have to check what I did in my fork branch to cook it that bad.

glromeo commented 9 months ago

the init compiler was in the render

glromeo commented 9 months ago

now I am going to fix the tests and release another version

glromeo commented 9 months ago

@NathanBeddoeWebDev

image

the compiler needs to be disposed at the end...that's why the tests where hanging

glromeo commented 9 months ago

@NathanBeddoeWebDev I am sorry that by making the PR myself you don't show up amongst the contributors if you want just create a PR for something silly like removing that semicolon at line 78 or I think I saw an unused import somewhere ...I will be glad to merge it 😆

NathanBeddoeWebDev commented 9 months ago

Haha, all good. I'm not a massive open sourcer so I don't really mind. Sass performance has just been something of a quest for me at work for the past year.