search

glromeo / esbuild-sass-plugin

esbuild plugin for sass
MIT License
153 stars 41 forks source link

sass-embedded is not supported on all platforms #168

Closed jelly closed 6 months ago

jelly commented 7 months ago

Since 3.0.0 this plugin switched to sass-embedded it now relies on binaries to be available for all platforms. We also build for s390x and aarch64 (and likely ppc64) for which sass-embedded does not distribute binaries.

Would it be possible to maybe allow for either sass or sass-embedded to be a dependency of esbuild-sass-plugin. Looking at sass-loader and vite. This seems to be something npm can support.

I'm happy to write a patch to make this happen.

glromeo commented 6 months ago

I am looking into trying and providing both sass as default to work on any platform and leave sass-embedded as an option ...thank you for spotting this shortcoming! It sucks indeed

glromeo commented 6 months ago

please let me know how it goes with v3.1.0

martinpitt commented 6 months ago

@glromeo Thanks a lot! It works very well indeed, ARM builds are happy again.