Fix Build2DMipmap causes exception on recent compilers like Delphi 10.4, 10.3

glscene / GLScene

GLScene is a graphics engine based on OpenGL with VCL components for Delphi & C++ Builder.

http://www.glscene.org

Mozilla Public License 2.0

216 stars 32 forks source link

Fix Build2DMipmap causes exception on recent compilers like Delphi 10.4, 10.3 #4

Closed benok closed 4 years ago

benok commented 4 years ago

Hi, thank you for maintaining GLScene. I really appreciate your work !

By the way, I found a problem around texture handling. Without this patch, yscale is set to NaN, and that causes overflow exception. (confirmed on Delphi 10.4 patch 3 &10.3.3)

Please check the attached sample. GLSTextureTest.zip

glscene commented 4 years ago

benok, Please, use official demos to show bugs before and after your patch to fix the exception. Paul

benok commented 4 years ago

OK, I'll try to find one, but it seems to depend on texture itself.

By the way, I found I have a mistake about commit's author & mail address fields. I need to filter my repo to correct.

So, I'll close this pull request first. I'll create another one, when it's ready.