search

gltf-rs / gltf

A crate for loading glTF 2.0
Apache License 2.0
535 stars 124 forks source link

separate import from loading data #244

Closed dakom closed 5 years ago

dakom commented 5 years ago

fixes #243

dakom commented 5 years ago

Doesn't seem like the AppVeyor build failing has anything to do with the code... any ideas?

alteous commented 5 years ago

Thanks for the PR. The AppVeyor build can be ignored as it's not setup yet.

To confirm: there is no functional change, right?

dakom commented 5 years ago

Right - for this PR all I did was separate out the image/base64/import helpers into a new feature called import_data_reference, and even with that, it's added to the default so there should be no change

dakom commented 5 years ago

Thanks for merging it!

FYI I didn't bump the version number, so if you have a continuous deployment setup, it'll need to be bumped first :)

alteous commented 5 years ago

I don't bump the version number until the last minute. The CI setup clones directly from master.