CubicSpline has same documentation as CatmullRomSpline

gltf-rs / gltf

A crate for loading glTF 2.0

Apache License 2.0

531 stars 123 forks source link

CubicSpline has same documentation as CatmullRomSpline #259

Closed rukai closed 5 years ago

rukai commented 5 years ago

Looks like the CubicSpline documentation was copy pasted from the CatmullRomSpline documentation and then not corrected. https://docs.rs/gltf/0.14.0/gltf/animation/enum.Interpolation.html

I looked up in the specs to see what it was supposed to be, but it doesn't exist??? So I'm a little confused, if it should actually exist at all. https://github.com/KhronosGroup/glTF/tree/master/specification/2.0

alteous commented 5 years ago

Oops, well spotted! Catmull-Rom splines were removed by https://github.com/KhronosGroup/glTF/pull/1171 back in December 2017. I kept it around in case somebody was depending on it but now that seems an unlikely scenario. I suggest we remove it entirely.