Fix `Normalize` for `u8`

gltf-rs / gltf

A crate for loading glTF 2.0

Apache License 2.0

534 stars 124 forks source link

Closed h3r2tic closed 2 years ago

h3r2tic commented 3 years ago

Hey! This fixes what looks like copy-paste errors in Normalize for u8

The impl Normalize<f32> for u8 was causing u8 vertex colors to appear black, and now exhibits the correct behavior.
The impl Normalize<u16> for u8 I did not test, but it follows the patterns of the other integer Normalize implementations.

alteous commented 2 years ago

Oops, well spotted. We'll mark this is a bug in the release notes.