search

gltf-rs / gltf

A crate for loading glTF 2.0
Apache License 2.0
535 stars 124 forks source link

Semver violating change in gltf-json v1.2 #380

Closed alice-i-cecile closed 1 year ago

alice-i-cecile commented 1 year ago

This appears to have broken fresh builds of Bevy: see this CI run for an example.

alteous commented 1 year ago

Thanks for reporting. For a long time the gltf-* crates have been published in lock-step with each other. The semver guarantee really only applied to the top-level gltf crate. This was discussed in https://github.com/gltf-rs/gltf/issues/241 a long time ago. The consensus of that issue was to make the other crates have proper semantic versioning but obviously that never happened.

In your run it looks like the problem is you are building both gltf 1.1 and 1.2, I imagine for export.

Compiling gltf-json v1.2.0
Compiling gltf v1.1.0
alice-i-cecile commented 1 year ago

Okay, useful background! We'll take a look and see what we can do.

alice-i-cecile commented 1 year ago

We can no longer reproduce this locally or in CI: maybe a caching issue. Anyways, I'll close this out: thanks for the help!