search

gltf-rs / gltf

A crate for loading glTF 2.0
Apache License 2.0
535 stars 124 forks source link

Allow handling large external buffers #396

Closed ShaddyDC closed 11 months ago

ShaddyDC commented 1 year ago

Closes #393

I've added a new error type for it to make failures explicit, but you could arguably also just use as usize and live with potentially weird behaviour when large values are truncated. Presumably, in those cases you'd crash anyway when trying to load the data into memory, though I haven't looked into it more.

I've also silenced some warnings in a separate commit by hiding them behind a cfg tag because they annoyed me during development, but I'm happy to remove those changes if you prefer.

ShaddyDC commented 11 months ago

@alteous thanks for merging this! When are you planning to do the next release?

alteous commented 11 months ago

Likely today or this weekend.