Open mestinso opened 7 years ago
Yes, you're probably right. Volunteers for a pull request?
I'll take a look at implementing this one in the next couple days. Any preference on lambaMax calculation method? I'm leaning towards using the estimated approach.
Thx! I'm really not the expert here, estimated approach sounds fine.
I am not sure why consistency checks are not a part of geomean and normalized mean methods. I would argue they should always be used and included.
Either lamdaMax could be calculated the proper way (same as eigenvalue method) or by using the standard lamdaMax estimation approach. Maybe the lamdaMax estimation approach makes the most sense here, since the only time you will know lamdaMax precisely is when you use the eigenvalue approach.
Thoughts?