search

glucauze / sd-webui-faceswaplab

Extended faceswap extension for StableDiffusion web-ui with multiple faceswaps, inpainting, checkpoints, ....
https://glucauze.github.io/sd-webui-faceswaplab/
GNU Affero General Public License v3.0
715 stars 92 forks source link

settings are not taken into account since v1.2.3 #62

Closed glucauze closed 11 months ago

glucauze commented 11 months ago

Problem : Settings are not taken into account when modified.

Reason : This is due to the way settings are no manage. Instead of using a lambda to load the settings (which takes a lot of time), i removed the settings from ui-config.json. This allows to manage the settings a lot more quickly.

Solution : Migration : YOU NEED TO recreate ui-config.json (delete and restart sd) OR at least remove any faceswaplab reference in the ui-config.json file to be able to use default settings again.

See this for explainations : https://github.com/AUTOMATIC1111/stable-diffusion-webui/issues/6109

abline11 commented 11 months ago

Unfortunately your mitigation that ' YOU NEED TO recreate ui-config.json (delete) or at least remove any faceswaplab reference to be able to use default settings again' doesn't work.

Having tried both deleting the ui-config.json file entirely so it is recreated AND editing the ui-config.json file to remove all lines referencing faceswaplab it will not remember any of the settings put into the txt2img tab under the FaceSwapLab V1.2.3 pull down in between sessions (i.e. if I go to the Setting tab, then the Defaults option, then click on View Changes, then Apply). In fact, it doesn't even pick up that there are any changes when View Changes is pressed. For example any changes to add a default Face Checkpoint (precedence over reference face) or Genger are not recognised and therefore forgotten.

I even deleted the entire FaceSwapLab extension, and the associated folders for FaceSwapLab in the Models and Extensions folders, and deleted the ui-config.json and once FaceSwapLab was reinstalled fresh still any changes applied in the txt2img tab are not remembered or even recognised when I have tried to set Defaults via the Settings tab.

This is a great extension. Please could you look at this again?

glucauze commented 11 months ago

Ok, reverting back would be easy but i need to be sure there is a problem first because the new way of handling parameters reduces load time drastically.

I have tested on linux on sdnext and a1111. I will try to test on windows. Edit : I did test on windows and it's working.

What is your configuration ?

The current version only store parameters that are set on SD setting tabs. Default checkpoint for instance is not possible. All otheer settings are lost. You also need to restart.

There are no settings stored in the ui-config.json as of now. Is that what you are looking for ?

abline11 commented 11 months ago

Hi,

I have a Windows 11 Alienware Laptop and am using standard A1111.

Just to be sure I also reinstalled a completely new clean version of A1111 and just added one single extra extension (i.e. FaceSwapLab) and it doesn’t work to remember any defaults set in the txt2img tab for FaceSwapLab.

Regards,

Andrew Brown

From: Tran Xen @.> Sent: 24 August 2023 13:15 To: glucauze/sd-webui-faceswaplab @.> Cc: abline11 @.>; Comment @.> Subject: Re: [glucauze/sd-webui-faceswaplab] settings are not taken into account since v1.2.3 (Issue #62)

Ok, reverting back would be easy but i need to be sure there is a problem first because the new way of handling parameters reduces load time drastically.

I have tested on linux on sdnext and a1111. I will try to test on windows.

What is your configuration ?

— Reply to this email directly, view it on GitHub https://github.com/glucauze/sd-webui-faceswaplab/issues/62#issuecomment-1691564809 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A5I3FXFBVICJ5SWJYSVBNBTXW5AUZANCNFSM6AAAAAA33MQH2E . You are receiving this because you commented. https://github.com/notifications/beacon/A5I3FXBETZZSR6QVCWI2GLLXW5AUZA5CNFSM6AAAAAA33MQH2GWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTE2M5QS.gif Message ID: @. @.> >

glucauze commented 11 months ago

Ok, just to be sure because it's puzzling me.

You are using these settings in sd settings :

And these settings are not reflected in txt2img parameters (after restart)?

Or you are expecting the configuration done in txt2img to be persistent (only when modifying it in txt2img tabs) ?

Where you using the settings before 1.2.3 ?

abline11 commented 11 months ago

Hi,

The settings under FaceSwapLab section are fine.

The settings under txdt2img which you should be able to make persistent by going to Settings/Default section are now not being stored as persistent or even recognised as changes you can view (see attached 2 screen shots).

If, for example, I change the Face Checkpoint to Face_3.safetensors it is impossible to make it persistent like all other changes in txt2img (e.g. Restore Faces or Seed)

I expect the configurations done in txt2img to be persistent as they always are if you use the Settings/Default. This facility has been available for months in A1111 and worked perfectly in V1.2.2, but is now broken in V1.2.3. Have you never used or tested the Settings/Default facility in A1111?

King regards,

Andrew Brown

From: Tran Xen @.> Sent: 24 August 2023 14:38 To: glucauze/sd-webui-faceswaplab @.> Cc: abline11 @.>; Comment @.> Subject: Re: [glucauze/sd-webui-faceswaplab] settings are not taken into account since v1.2.3 (Issue #62)

Ok, just to be sure because it's puzzling me.

You are using these setting :

https://user-images.githubusercontent.com/137925069/258478052-0cfdc09c-36ce-4cb4-96a4-ddb0a9d4aee4.png

And these settings are not reflected in txt2img parameters?

Or you are expecting the configuration done in txt2img to be persistent ?

— Reply to this email directly, view it on GitHub https://github.com/glucauze/sd-webui-faceswaplab/issues/62#issuecomment-1691695658 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A5I3FXBQNEWIR5ZUGQ42EFLXW5KNFANCNFSM6AAAAAA33MQH2E . You are receiving this because you commented. https://github.com/notifications/beacon/A5I3FXHLMZ4IVVYESGQ7M7DXW5KNFA5CNFSM6AAAAAA33MQH2GWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTE2U5CU.gif Message ID: @. @.> >

glucauze commented 11 months ago

Ok thanks ! I got it :

If, for example, I change the Face Checkpoint to Face_3.safetensors it is impossible to make it persistent like all other changes in txt2img (e.g. Restore Faces or Seed)

I made settings do_not_save to be able to adjust settings by myself.

I expect the configurations done in txt2img to be persistent as they always are if you use the Settings/Default. This facility has been available for months in A1111 and worked perfectly in V1.2.2, but is now broken in V1.2.3. Have you never used or tested the Settings/Default facility in A1111?

I don't use this option. That's why. Settings cannot be managed by faceswaplab OR sd. I had to made a choice but but I applied this to all the changes.

I will try to think of a way to handle that properly. I hope it's not too critical in the meantime.

I can mark only the options I set as "do not save" and leave the others or i can add options in the settings. Or i can suppress the default settings in faceswaplab and let the users use the default interface (don't know if it is more user friendly)

Btw i don't see the screenshots, i think they are not uploaded when you reply by mail.

glucauze commented 11 months ago

I made a change to mark only fields that are not managed in faceswaplab settings. I think it is working. Would you have time to try and tell me if it is better for you ?

abline11 commented 11 months ago

Yes. Of course I would like to try it. It’s a great extension. Much better than roop which can only take one face and merge that in. I’m out getting some food. I’ll try when I get home. But … how do I try your changes?  I’ve gone back to V1.2.2. How do I install your revised V1.2.3 (or a V1.2.4)??Sent from my iPhoneOn 24 Aug 2023, at 18:22, Tran Xen @.***> wrote: I made a change to mark only fields that are not managed in faceswaplab settings. I think it is working. Would you have time to try and tell me if it is better for you ?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

glucauze commented 11 months ago

Don't worry about that, since all the tests are ok and the change is not critical, i will merge the version. You can tell me if it's better by just reinstalling the main branch.

glucauze commented 11 months ago

Reopening (the merge has closed the issue). Will close if you confirm it works properly.

I have opened a poll in discussion section to ask if faceswaplab should manage default settings : https://github.com/glucauze/sd-webui-faceswaplab/discussions/69

I am starting to think it's a redundant functionality and error-prone. Thanks for making me discover the feature.

abline11 commented 11 months ago

It certainly seems to now recognise the changes I make in txt2img and, via the Setting/Defaults section, allow me to both view the changes I have made and save them for the next time I open A1111 (see attached screenshot).

Well done for such a quick fix!

From: Tran Xen @.> Sent: 24 August 2023 18:37 To: glucauze/sd-webui-faceswaplab @.> Cc: abline11 @.>; Comment @.> Subject: Re: [glucauze/sd-webui-faceswaplab] settings are not taken into account since v1.2.3 (Issue #62)

Reopening (the merge has closed the issue). Will close if you confirm it works properly.

— Reply to this email directly, view it on GitHub https://github.com/glucauze/sd-webui-faceswaplab/issues/62#issuecomment-1692143769 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A5I3FXHLFXLZNI2MQVYSZJLXW6GKXANCNFSM6AAAAAA33MQH2E . You are receiving this because you commented. https://github.com/notifications/beacon/A5I3FXE5C7YKBMA5PBGEPWDXW6GKXA5CNFSM6AAAAAA33MQH2GWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTE3QIJS.gif Message ID: @. @.> >

abline11 commented 11 months ago

Thank you very much.

From: Tran Xen @.> Sent: 24 August 2023 22:07 To: glucauze/sd-webui-faceswaplab @.> Cc: abline11 @.>; Comment @.> Subject: Re: [glucauze/sd-webui-faceswaplab] settings are not taken into account since v1.2.3 (Issue #62)

Closed #62 https://github.com/glucauze/sd-webui-faceswaplab/issues/62 as completed.

— Reply to this email directly, view it on GitHub https://github.com/glucauze/sd-webui-faceswaplab/issues/62#event-10186040864 , or unsubscribe https://github.com/notifications/unsubscribe-auth/A5I3FXAZXBONLWNKKDT3OALXW667NANCNFSM6AAAAAA33MQH2E . You are receiving this because you commented. https://github.com/notifications/beacon/A5I3FXCUIWTLTHYID4B7RMLXW667NA5CNFSM6AAAAAA33MQH2GWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAEXZCUYQA.gif Message ID: @. @.> >