search

gluck / il-repack

Open-source alternative to ILMerge
Apache License 2.0
1.19k stars 217 forks source link

Add NuGet license information to .nuspec #310

Closed jonpryor closed 2 years ago

jonpryor commented 2 years ago

Context: https://docs.microsoft.com/en-us/nuget/reference/nuspec#license Context: https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/nuget#important-nuget-package-metadata Context: https://docs.clearlydefined.io/curation-guidelines

Certain internal Microsoft tools check NuGet license information by using ClearlyDefined curated data to determine verified license information for packages which don't "clearly define" their license.

The ILRepack and ILRepack.Lib NuGet packages do no specify any license information within their .nuspec files.

Update build.groovy so that the generated .nuspec files contain the ` element:

<license type="expression">Apache-2.0</license>

The value of the <license/> element must be an SPDX license identifier.

This is slightly complicated by the fact that I can't find an easy way to get com.ullink.nuget to emit XML attributes. Fortunately, if it processes a closure, we can get access to the underlying MarkupBuilder instance, which allows us to create an XML element that contains both attributes and content.

gluck commented 2 years ago

Thanks for the clean PR. Unfortunately I have moved on from .Net and can no longer build/release this project (not even sure the release script still works).

LMK if you feel like releasing a patch (don't know how much you need it), and I can DM you a temporary API key for it.

KirillOsenkov commented 11 months ago

Hi @gluck thank you so much for everything you've done for .NET. This project is amazing and is still being super useful for the whole ecosystem.

Would you be interested in adding me as an owner to this project so I could continue maintaining it, merging PRs, making releases? Ideally also I'd need to be an owner on https://www.nuget.org/packages/ILRepack to be able to publish new versions.

If not, no problem, my current plan is to merge PRs into my fork and publish a NuGet with a different ID.

Thanks again!

gluck commented 11 months ago

Hi @KirillOsenkov ,

happy to do so, I've moved on from .Net, doesn't mean everybody should ! I've invited you to the GitHub repo, will do on nuget next.

@timotei is that alright with you being both collaborators on this repo ?

timotei commented 11 months ago

@gluck Sure 👍 I wasn't able to be properly involved in the past year(s) :(, so having another collaborator is great

Welcome @KirillOsenkov 👋

KirillOsenkov commented 11 months ago

Amazing! my nuget.org account is https://www.nuget.org/profiles/kirillosenkov