search

gluck / il-repack

Open-source alternative to ILMerge
Apache License 2.0
1.16k stars 214 forks source link

Proposal: Rename /ExcludeInternalizeSerializable to /InternalizeSerializable #344

Closed mayermart closed 7 months ago

mayermart commented 8 months ago

ExcludeInternalizeSerializable is hard to read and understand. Would it make sense to rename it to InternalizeSerializable or at least InternalizeExcludeSerializable ?

In my opinion it would better match the options Internalize and InternalizeExclude

KirillOsenkov commented 8 months ago

we want to internalize by default, so a flag needs to be the opposite of default. I know it does sound awkward, but it will be used very infrequently and users will figure it out. InternalizeExcludeSerializable is marginally better so not worth the churn, sorry.