search

gluck / il-repack

Open-source alternative to ILMerge
Apache License 2.0
1.16k stars 214 forks source link

Exceptions aren't renamed? #350

Closed johnterickson closed 7 months ago

johnterickson commented 7 months ago

It looks like exceptions aren't renamed. Is this expected or should I fork and PR?

repro: git clone https://github.com/microsoft/MSBuildCache.git git checkout 8bc8b88c216f3854c5c256c794e5fe912717f6e0 dotnet build MSBuildCache.sln --configuration Release /bl

Image

KirillOsenkov commented 7 months ago

We don't rename types marked as serializable but there's a command line option to override that

johnterickson commented 7 months ago

It's @KirillOsenkov! Thank you, sir :)

johnterickson commented 7 months ago

Ah looks like this was fixed in 2.026. I was on 2.025. Keep up the great work!